tweet_historical_event() in tweet_historical_events.py needs some tweaks to be functional about lgbtq-of-the-day-bot HOT 9 CLOSED

I'm working on this, just waiting for current PRs to merge before submitting a PR for this. This is so exciting 😁👌🤯

from lgbtq-of-the-day-bot.

You're not overwhelming. It's just new to me.

I actually just closed their PR. You had already created the issue. Their contribution was after you'd identified the issue and said you'd work it.

from lgbtq-of-the-day-bot.

It's new to me as well so I know how you feel! You're doing great. Please please let me know if I can be of any extra help! I'm glad to contribute and stuffs 👌. PR is up.

from lgbtq-of-the-day-bot.

I'm going through and merging everything now.

from lgbtq-of-the-day-bot.

Thanks for getting back to me! I saw that somebody else has submitted a PR for this #42 . The only difference between my solution (no PR yet) is that when there are multiple events on the same date, it would generate it randomly. Would you still want me to submit a PR for you to see ? @VickiLanger

from lgbtq-of-the-day-bot.

I left that one for last because I didn't want to ignore that you were working on it. I like the idea of having it randomly choose if there are multiple events. That makes sense.
@bobsany16

from lgbtq-of-the-day-bot.

ah thank you! I'll have a PR up soon :) @VickiLanger

from lgbtq-of-the-day-bot.

It's new to me to have multiple PRs for the same issue. Should I merge their PR or just take your's when you submit it?

from lgbtq-of-the-day-bot.

I'm sorry if it's somewhat overwhelming! Well, I think you should merge their changes (they should resolve the conflict before you merge) just so their contribution doesn't get wasted. Then I'll just update my local repo and put in my changes then make a PR.

from lgbtq-of-the-day-bot.