Importing a .vespene file the variables are stored using single quotes instead of double quotes making the json invalid about _old_vespene HOT 7 CLOSED

Hi @AicyDC - it looks like I didn't actually try using the "variables" portion of the .vespene file - good catch and thanks for the report.

The code in question is https://github.com/vespene-io/vespene/blob/master/vespene/workers/importer.py

As you can see, it has no special value handling in 'attr_manage()' for the variables field, and it should.

What we should do is check if the type of any field is a dict, and if so, save the JSON version of that value.

What is happening is you are getting the stringification of the dictionary field, which is obviously no good.

I should be able to get to this in the next few days unless you want to have a go at it.

from _old_vespene.

essentially it just needs something like this:

if type(value) == dict:
    value = json.dumps(value)

from _old_vespene.

or better, probably:

value = json.dumps(value, indent=4)

(This preserves format because we are still storing those as text for slightly better DB compatibility, and because of some issues with the forms code and the JSON field class)

from _old_vespene.

Thanks for the quick reply, unfortunately I do not know python very well so will not be having a go at it myself.

from _old_vespene.

No problem!

from _old_vespene.

Just wanted to say I haven't forgotten about this one. Various other things coming up but this should still be an easy change. Thanks for all the forum feedback!

from _old_vespene.

Apologies on losing track of this one, I've just pushed the two line fix mentioned above.

Thanks!

from _old_vespene.