Update extensions.gnome.org about gnome-disable-gestures HOT 6 CLOSED

Actually I attempted to publish a new version v6 to extensions.gnome.org but got rejected because of the code did not meet the coding standard. Unfortunately I no longer have the hardware and environment to test the plugin even if I update the code, and that’s why the plugin didn’t got updated on the site.

Let me try revising the code and publish a new version again, but without testing. Hopefully there is no issue with the revise code 🥲

from gnome-disable-gestures.

As new version v7 has been published on extensions.gnome.org using code revised in commit ef41b66, this issue is resolved. Closing the issue.

from gnome-disable-gestures.

New version works as expected, including disable functionality! Thanks for taking the time to do this!

from gnome-disable-gestures.

I can test for you if you want! I already tested the master branch (as of when I posted this issue) and it works fine. If you push a change that you want me to test, just reply here and I'll try it out. I don't have experience with javascript or developing gnome extensions, but I know how to run them from source.

The plugin is so small, it's very strange that it doesn't meet their """coding standard.""" 😕 Does it say anything more than it doesn't meet the standard?

from gnome-disable-gestures.

Also, while we're on this topic, it might be good to update the repository url to refer to the extension's page on extensions.gnome.org. Right now the repository URL is not set.

example from another repo	this repo

(I can make another issue for this if you'd like)

from gnome-disable-gestures.

I can test for you if you want!

That will be great. New version v7 has been published to extensions.gnome.org. If you have the time please install the v7 extension and let me know if there is any issue.

The plugin is so small, it's very strange that it doesn't meet their """coding standard.""" 😕 Does it say anything more than it doesn't meet the standard?

Yes, the reviewer did provide useful feedback. Maybe my word "coding standard" is not that appropriate. In simple word, the previous code did not properly released some resources when the extension disable. As most people using this extension are unlikely to disable the extension, that's probably why issues didn't surface. If you are interested in the details, there is a page about the extension approval which you can read.

it might be good to update the repository url to refer to the extension's page on extensions.gnome.org. Right now the repository URL is not set.

Thanks for point that out 😃, I have updated the URL and added tags to this repo for completeness.

from gnome-disable-gestures.