New web client expectation, result type differ from error type about vertx-web HOT 5 OPEN

more thoughts about this: since expecting is a construct that operates at the future level and not the http request/response api level, there is no way we can have the decoding happening after the expectation.

Instead the Future.map operator should be used, so the code would actually be like:

webClient
    .get("/test")
    .expecting(expectation)
    .map(response -> response.bodyAsJson(Integer.class));

Therefore we might have to deprecate the the as on HttpRequest to discourage using it, if that can be replaced by the use of map.

from vertx-web.

cc @vietj

from vertx-web.

thanks I'll have a look

from vertx-web.

I see the behaviour is different for this case, I am thinking that the decoding of the body should be applied only when responses are 2xx that would fix this issue

from vertx-web.

The body may contain useful information (e.g. problem ID) in case of an error response. How can we get it?

from vertx-web.