Code Monkey home page Code Monkey logo

Comments (6)

cescoffier avatar cescoffier commented on July 20, 2024

These lines do not override the CredentialProvider.
I'm more worried by

.setTransportConfigCallback(transportConfigCallback)
. We should check for null before setting them.

Can you check and open a PR?

from vertx-config.

Trumeet avatar Trumeet commented on July 20, 2024

@cescoffier Sorry, I'm currently not understanding these codes enough...

from vertx-config.

SINGS079 avatar SINGS079 commented on July 20, 2024

@cescoffier @Trumeet let me take a look at this issue. If anyone is already working on this let me know here.

from vertx-config.

cescoffier avatar cescoffier commented on July 20, 2024

Thanks @SINGS079 !

from vertx-config.

SINGS079 avatar SINGS079 commented on July 20, 2024

the issue is with this line where CredentialProvider is missing in case of Username and password authenticated Repo
(

call = git.pull().setRemote(remote).setRemoteBranchName(branch).call();
)

I'm creating a pull request with this fix. Tested with my personal repo.

from vertx-config.

SINGS079 avatar SINGS079 commented on July 20, 2024

Can we close this issue as this is already resolved?

from vertx-config.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.