Code Monkey home page Code Monkey logo

Comments (15)

cescoffier avatar cescoffier commented on August 20, 2024

@vietj do you know why we could have this ?

I will try to come up with a reproducer.

from vertx-config.

vietj avatar vietj commented on August 20, 2024

it could be that the user has not vertx-lang-groovy in the classpath but still has the Groovy jar that loads the groovy extension.

from vertx-config.

cazacugmihai avatar cazacugmihai commented on August 20, 2024

Yes, the groovy-all jar is present in my classpath but I think that I should't be forced to add an extra dependency (vertx-lang-groovy) in case of using vertx-config.

from vertx-config.

vietj avatar vietj commented on August 20, 2024

@cazacugmihai we don't enforce you to do so, let us find a better solution to that

from vertx-config.

vietj avatar vietj commented on August 20, 2024

I beleive that the ConversionHelper code is small and generic enough to be moved somewhere in Vert.x core

from vertx-config.

vietj avatar vietj commented on August 20, 2024

and the problem it tries to solve is converting object / object in a generic manner

from vertx-config.

vietj avatar vietj commented on August 20, 2024

well it does reference gstring :)

from vertx-config.

vietj avatar vietj commented on August 20, 2024

but gstring is CharSequence

from vertx-config.

cazacugmihai avatar cazacugmihai commented on August 20, 2024

I'm sure that this was not done intentionally. Thanks for your investigation!

from vertx-config.

vietj avatar vietj commented on August 20, 2024

nope, another way is to use an extension factory that tries to load the various classes

from vertx-config.

vietj avatar vietj commented on August 20, 2024

but anyway just stay tuned in this thread and be ready to try a solution to confirm it's cool for you

from vertx-config.

cazacugmihai avatar cazacugmihai commented on August 20, 2024

Sure. I'll be waiting for it. Thanks!

from vertx-config.

vietj avatar vietj commented on August 20, 2024

@cazacugmihai can you give a try ? now the generated code should not need vertx-lang-groovy anymore. I've pushed new snapshots for vertx-config (the CI should deploy new snapshots also at some point).

from vertx-config.

cazacugmihai avatar cazacugmihai commented on August 20, 2024

I'm trying right now.

from vertx-config.

cazacugmihai avatar cazacugmihai commented on August 20, 2024

Everything works fine now. Thanks!

from vertx-config.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.