Code Monkey home page Code Monkey logo

Comments (4)

seiyria avatar seiyria commented on September 3, 2024

Yes, this would be fine, provided the original functionality was retained. We currently do not need something like this, but if you submitted a pull request, I'd accept it.

You could probably find the equivalent vanilla JS functions for the jquery functionality, since it seems like it's only used in toTheLeft and toTheRight (as you said).

from angular-ui-tab-scroll.

PaulL1 avatar PaulL1 commented on September 3, 2024

I also see only mousedown/mouseup, not touchstart and touchend. Does it work well on touch devices? I know many emulate the mouse events, so perhaps you don't need touch events?

Further, getting my head around what it does - the tooltip seems to be the thing that requires jQuery, but the tooltip is also influencing the enabling of the left and right buttons. So I could perhaps (for my purposes) end up with something much simpler if I didn't need the tooltips.

from angular-ui-tab-scroll.

seiyria avatar seiyria commented on September 3, 2024

I have honestly never tested it on touchscreen devices. This is only in use in one place in our app so far, and mobile users won't ever go there, probably. If you wanted to do some recognition to determine the proper event to bind, I wouldn't be opposed.

Yes, essentially whether or not there is a tooltip determines the visibility of the buttons. It's a coupling I'm not happy to have, but this solution had to happen within a short timeframe, so improvements are welcome. :D

from angular-ui-tab-scroll.

Shemesh avatar Shemesh commented on September 3, 2024

@PaulL1 the latest versions do not use jQuery at all, the jQuery dependency was removed!

from angular-ui-tab-scroll.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.