[Bug]: Outgoing QoS upgrades not affecting storage of offline messages about vernemq HOT 5 CLOSED

@micw thanks, something smells wrong here.
I think we fail to add a message id and do not add the "QoS-0-message-which-is-now-a-Qos>0-message" to the waiting acks and replay queue in the FSM statemachines.
I agree the behaviour you expect is what the option promises. So, should be somehow fixed and aligned, even if it's a non-spec option. ("We have left MQTT jurisdiction").

This is somewhat low-priority for me but feel free to propose a fix, if it's urgent for your use case.

👉 Thank you for supporting VerneMQ: https://github.com/sponsors/vernemq
👉 Using the binary VerneMQ packages commercially (.deb/.rpm/Docker) requires a paid subscription.

from vernemq.

The upgrade is done too late (the decision to store on disk or not has already been made). The upgrade should be moved to the earliest possible moment (maybe in vmq_queue, and not in mqtt_fsm)

from vernemq.

@mths1 Thanks for the PR! @micw can you give it a try? #2221

👉 Thank you for supporting VerneMQ: https://github.com/sponsors/vernemq
👉 Using the binary VerneMQ packages commercially (.deb/.rpm/Docker) requires a paid subscription.

from vernemq.

Test plan:

1. publish without client connected and without any sessions

mosquitto_pub -t "test1" -m "test.q0" -q 0
mosquitto_pub -t "test1" -m "test.q1" -q 1

2. subscribe with a client, qos=1, clear-session=false

mosquitto_sub -t 'test1' -q 1 -i c1 -c -d

Expected result: no messages are received - PASS

3. publish with client connected

mosquitto_pub -t "test1" -m "test.q0" -q 0
mosquitto_pub -t "test1" -m "test.q1" -q 1

Expected result: both messages are received by the connected client. Both have qos 1 - PASS

4. disconnect the client, publish with client disconnected and existing offline session

mosquitto_pub -t "test1" -m "test.q0" -q 0
mosquitto_pub -t "test1" -m "test.q1" -q 1

5. subscribe with the same client id again, qos=1, clear-session=false

mosquitto_sub -t 'test1' -q 1 -i c1 -c -d

Expected result: both offline messages are received by the client. Both have qos 1 - PASS

Works for me.

from vernemq.

@micw thanks for verifying! cc @mths1

👉 Thank you for supporting VerneMQ: https://github.com/sponsors/vernemq
👉 Using the binary VerneMQ packages commercially (.deb/.rpm/Docker) requires a paid subscription.

from vernemq.