Code Monkey home page Code Monkey logo

Comments (6)

eldor avatar eldor commented on September 24, 2024 2

I've added version 3.0.2 that have the new command: https://github.com/vemcogroup/laravel-translation/releases/tag/3.0.2
Could you test it out and let me know if there is any issues

from laravel-translation.

eldor avatar eldor commented on September 24, 2024

Hi @nicolasbuch
Thank you for the kind words.

Have you tried using the scan method before using upload?

php artisan translation:scan {--merge : Whether the job should overwrite or merge new translations keys}

Then I think it keeps the other translations in your file.

from laravel-translation.

nicolasbuch avatar nicolasbuch commented on September 24, 2024

Have you tried using the scan method before using upload?

php artisan translation:scan {--merge : Whether the job should overwrite or merge new translations keys}

Yes sure, this is what we do today. The php artisan translation:scan --merge command does not help us, because the translations from "feature 1" simply dont exist in the branch of "feature 2".

Our CI/CD setup will run below on each merged PR:

php artisan translation:download
php artisan translation:scan --merge
php artisan translation:upload

UPDATED: diagram (working on two release versions at the same time):

/master
|
|_ _ /release/a
|       |
|       |_ /feature/1
|          |
|          |_ new translations pushed when "feature 1" is merged into "release a"
|
|_ _ /release/b
        |
        |_ /feature/2
           |
           |_ new translations pushed when "feature 2" is merged into "release b"
           |_ translations from "feature 1" removed from POEditor due to sync strategy

Hope this makes a bit more sense

from laravel-translation.

eldor avatar eldor commented on September 24, 2024

Ok, now i see what you mean and can understand your issue.
We could make another command like php artisan translation:terms that only add terms to PoEditor.

https://poeditor.com/docs/api#terms_add

Then you dont need to run the upload command only scan -> terms -> download and it shouldn't remove terms anymore.

Would that be a suitable solutions for you guys?

from laravel-translation.

nicolasbuch avatar nicolasbuch commented on September 24, 2024

Would that be a suitable solutions for you guys?

That would be amazing! Let me know if there is anything I can do to assist

from laravel-translation.

nicolasbuch avatar nicolasbuch commented on September 24, 2024

Could you test it out and let me know if there is any issues

Works like a charm, thank you!

from laravel-translation.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.