Server should remove player entity when player disconnects about veloren HOT 3 CLOSED

This is caused by the client failing to send a Disconnect packet to the server, due to the fact that the main thread ending in voxygen never gives the client threads time to do so.

Possible solution: refactor connection status to be a state machine rather than a simple boolean. The main thread should only shutdown once a terminal state is reached (i.e: with something like Client::wait_for_shutdown(client)).

Suggested states:

enum ClientState {
    PortNotBound,
    PendingConnection,
    DisconnectSent,
    Disconnected,
}

from veloren.

Removed 'good first issue' because solving this properly is something that requires refactoring a fair few things within the client.

from veloren.

I've partially solved this by fixing the client connection status system. It's now more of a state machine than a boolean "is/is not connected" thing. This means it does actually send a disconnect packet.

This also needs to be fixed server-side, but I feel like this plays into @terahxluna's event dispatching and server refactoring efforts now.

from veloren.