Code Monkey home page Code Monkey logo

Comments (3)

LandonTClipp avatar LandonTClipp commented on July 22, 2024

Why not just have fooExp be fooExp: func(t *testing.T) *mocksFoo that returns the instantiated mock with expectations already added?

foo := tt.fooExp(t)

from mockery.

Thiht avatar Thiht commented on July 22, 2024

It's a pretty good solution that I did not think of (thanks for the suggestion, I'll probably use that if this doesn't get added!). I like that it keeps the mock initialization and setup together.

The only disadvantage I see is that it's a bit more verbose (2 more lines per expect function so if the table has >10 tests it can pile up) but I can live with that:

fooExp: func(m *mocks.Foo) {
    m.EXPECT().DoSomething().Return(nil)
}

// vs

fooExp: func(t *testing.T) *mocks.Foo {
    m := mocks.NewFoo(t)
    m.EXPECT().DoSomething().Return(nil)
    return m
}

from mockery.

LandonTClipp avatar LandonTClipp commented on July 22, 2024

That's great. FWIW add a nil-check in the t.Run around tt.fooExp(foo) is not a bad option in my opinion. This would probably be my preferred solution. But yeah, if there is an easy way around your problem, I prefer not to add to the mock objects.

from mockery.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.