Wrong code generation when using ellipsis about mockery HOT 4 CLOSED

The issue most likely resides somewhere here. Specifically, it would be this switch case. Mockery may be accidentally throwing away the variadic-ness about this variable type.

This should be very easy to fix, because the types.Type object has a Variadic() bool method that tells you if it's, well, variadic. Then the renderTypeTuple method can be updated to print the correct ellipsis, instead of a slice.

There's the other consideration that you could technically have an arbitrarily deep nested function declaration

type ExposedFunction func(args ...func(args ...func(args ...bool))) interface{}

So the real solution would involve recursion, but I've never seen something like this out in the wild.

from mockery.

Thank you for your feedback, yes, handling the recursion now may be overkill.

What is the next step? I can do a PR to handle the case, but it will take me some time to ramp up on the project.

from mockery.

What time frame are you looking at to get a PR @nicovak? I'm always willing to do some dev work myself but we all lead busy lives so not sure how quickly I could do it.

from mockery.

Closing in favor of #431 as this is a duplicate issue. The solution lies within the code block I mentioned.

from mockery.