Code Monkey home page Code Monkey logo

Comments (8)

veista avatar veista commented on July 21, 2024 1

Sorry, I don't have time to look into this right now. Could not fix it easily, there is some issue introduced to the modbus wrapper on HA after making it async.

I would hold on updating/roll back for now.

from nilan.

jamespreedy avatar jamespreedy commented on July 21, 2024 1

@AdamGrumlik - see viesta's comment above.
He's the author of the integration, is aware of the issue with 2024.4 but doesn't have time to look at this at the moment.

Best advise at this point is to roll back for now if you've already updated and the Nilan integration is required. 👍🏻

from nilan.

jamespreedy avatar jamespreedy commented on July 21, 2024

Same, please let me know if I can provide any logs etc that could help. Thanks!

from nilan.

jseedorff avatar jseedorff commented on July 21, 2024

Same here. I get a timeout when the integration attempts to connect to my Modbus gateway.

from nilan.

AdamGrumlik avatar AdamGrumlik commented on July 21, 2024

2024.4.0 Integration not working:(

from nilan.

kfroeschl avatar kfroeschl commented on July 21, 2024

I think I've found the issue,

HA ModbusHub is now fully async:
home-assistant/core@7cba34b

and thus the success = await self._modbus.async_setup()(device.py) call does no longer wait for the connection to be established.

in my local workaround i've added a await asyncio.sleep(10) right after to get it running again for now.
Though this is far from a beautiful solution it works for now.

(+ I've added the await before await self._modbus.async_close() to avoid another error)

from nilan.

veista avatar veista commented on July 21, 2024

Great! Can you make a pull request?

from nilan.

kfroeschl avatar kfroeschl commented on July 21, 2024

#124

from nilan.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.