Comments (7)
Hi @alectogeek !
It looks from the code that the function passed to Appodeal.setNonSkippableCallback
would never trigger, will look into this.
I can also confirm that the function passed to Appodeal.setRewardCallback
is also called for non skippable (and vice versa).
from flutter-appodeal.
@alectogeek Thanks for reporting this bug.
@nixxxon Thank you too for your willingness to look into this issue. Actually I was already looking at this problem some time ago and I also found the problem in the line below: https://github.com/vegidio-flutter/appodeal/blob/be9e15bd0b33f499be9685ff2e2e519b1683f356/lib/src/appodeal.dart#L105
It was previously calling onRewarded
instead of onNonSkippable
🤦♂️
I fixed this now and I also did some small code refactoring (I separated the callbacks in different files on Android), but for some reason the the Reward ads are still triggering the Non-Skippable callbacks, and vice-versa.
Unfortunately I don't have much time now to continue the investigation because my primary job is taking a lot of my time, but I decided to push the changes that I did so far to master
. In case you, or anybody else, is interested to continue the investigation of this issue then you are welcome to do so and open a PR 🙂
Thanks for contributing to this project!
from flutter-appodeal.
I just got a reply from Appodeal, turns out that this is an expected behavior since non-skippable video inherits methods and properties from rewarded videos.
It actually looks like the reversed from this image (reward inherits from non-skippable?):
Seems a bit weird but I guess it's not coming from the plugin then. Need to understand the plugin more to say if there is something to do about it.
from flutter-appodeal.
@vegidio No problem, it's only fair since we are quite dependent on your plugin - thank you for creating it 👏
I couldn't find anything else that seemed wrong with the callback code (other than the fix you mentioned). I've asked Appodeal if its a known bug within the SDK.
Will continue with the investigation and keep you posted here.
from flutter-appodeal.
Hi @nixxxon, thank you very much for following up with Appoeal support team about this issue. It was actually driving me crazy because I had no idea why it was still failing even though the bug was fixed 😅
In any case, in my opinion it's a little weird how even though the Non-Skippable ads inherit from Reward (or vice-versa), when we present one of them it triggers the callback of both types of ads 🤷♂️ - They say that this behavior is expected, but it doesn't look very practical for us, developers.
Oh well, it seems that we can't do much to fix this problem them. What do you think?
from flutter-appodeal.
@vegidio I totally agree. Will dig through the code some more, but I'm afraid it's not much that we can do about it.. 😞
from flutter-appodeal.
Yeah, unfortunately it seems there's not much we can do for now since this behavior is coming from the Appodeal lib. We can come back to this issue again in the future if the Appodeal guys ever decide to do something about it. But thanks again @nixxxon for helping with this :)
@alectogeek Sorry we couldn't find a solution for your problem. There was indeed a bug in the plugin's code, but I could never imagine there was also a problem in the way Appodeal lib for Android and iOS was designed.
from flutter-appodeal.
Related Issues (20)
- Null-safety support? HOT 2
- Can you please support Native ad? HOT 7
- App crashes while initializing Appodeal in the latest version (1.0.0) HOT 9
- [Feature request] MREC support HOT 2
- v1.1.0 Error: Could not find ads-sdk-3.7.1.4.aar (com.pangle.global:ads-sdk:3.7.1.4). HOT 4
- Update skd to 2.10.2 (6 August, 2021) HOT 1
- var userConsent = await Appodeal.fetchConsentInfo() return null exception HOT 5
- Platform exception in Android Tv HOT 2
- Set UserId for server-to-server (S2S) rewarded video callbacks HOT 1
- crash - app crashes when launching intestitial or reward ad HOT 2
- Can't test the example HOT 1
- How to show bigger banner ads?
- Incompatible version of Kotlin HOT 1
- Example not working on real iOS device HOT 1
- SKAdNetworkIdentifier missing
- NSUserTrackingUsageDescription data collection HOT 1
- Appodeal.destroy is missing
- Error installing AppRollSDK HOT 5
- Could you please Upgrade to Appodeal SDK 2.10.3+
- Ios pod error
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flutter-appodeal.