Code Monkey home page Code Monkey logo

Comments (4)

AliciaSchep avatar AliciaSchep commented on May 30, 2024

Should this be harmonization to v2.0.1 now? 😄

One note on these vars -- I think the VEGA_EMBED one might be a bit out-of-date (also only 2 instead of three numbers). Just pulled v2.0.1 and the VEGALITE_VERSION seemed right but not the VEGAEMBED_VERSION. Looking at the altair source code it appears that VEGA_EMBED variable is hard-coded, while VEGALITE is pulled from someplace else. So my guess is that the VEGA_EMBED one may not reliably be updated.

I'm also not totally sure if the version of vega-embed has to match altair, in that Altair the python package does not do rendering, but I could be mistaken. In the html template in Altair, they just call the @2 and @3 versions for vega-lite and vega-embed.

from altair.

ijlyttle avatar ijlyttle commented on May 30, 2024

I get your comment on v.2.0.1... believe me, I get it 😩😁

I would like to make a practice run of what we will need to do for v2.0.x, so I am thinking to try it out for v2.0.0rc2. Putting this effort into "this " version seems a little bittersweet, because we will have this (for the most part) working version, complete with tooltips, then disassemble it in favor of v2.0.x ...

The VEGAEMBED_VERSION, etc., seemed too good to be true ...

I had been thinking about this for a little while, now that you bring up the @2 and @3 in the htmltemplate, this might be the occasion to discuss the idea.

As you know, the htmlwidgets philosophy dictates that we pick specific versions of JS libraries, not just the major version. So my idea is just to "plant our flag" somewhere, as is done now. For example, to pick a version for vega_embed, my default would be to pick the version that was most-recently tagged when v2.0.0rc2 was tagged. Again, I'm not saying anything you don't already know - this is mainly to make sure I can explain the idea to myself (and remember it 🤓).

This puts the onus on us to make new releases every so often based on updates to the JS libraries, but I guess that's (htmlwidgets) life.

Where this idea might become interesting is in the implementation of #19, a function, create_block(), that would use gistr to make something available to bl.ocks.org. For that function, I think the default would have to be to use specific JS versions in the html template, simply for reproducibility.

Then, I think it would be really cool to supply some JS widgets in the block that could update the block's HTML template to specify the (major) versions of each of the libraries - which could help us determine if the "water is safe".

Anyhow, I should get back to that contribution guide...

from altair.

ijlyttle avatar ijlyttle commented on May 30, 2024

Now that I have a record of how the tooltips worked in the "old" way, I am thinking just to go straight to v2.0.1.

from altair.

ijlyttle avatar ijlyttle commented on May 30, 2024

closing in favor of #33

from altair.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.