Code Monkey home page Code Monkey logo

Comments (5)

kristw avatar kristw commented on August 24, 2024 1

Addressed in version 4.0.1.
Thank you for reporting!

from react-vega.

kristw avatar kristw commented on August 24, 2024

react-vega lists vega-lib as peerDependencies, which I trace the dependencies and vega-lib 4.2 use d3-format 1.3

https://github.com/vega/vega-lib/blob/master/yarn.lock

so I am not sure why you got d3-format 1.2.
Are you using yarn or npm?
This is a dumb ask , but have you try yarn install again? or remove node_modules entirely and install?

from react-vega.

visnup avatar visnup commented on August 24, 2024

I've been using yarn. and yeah, I've tried yarn install a couple times along with removing node_modules too.

To be clear, I'm pretty sure you or whoever published to npm last also resolves to [email protected] because the dist file I believe contains [email protected]. Maybe check with yarn list --pattern d3-format?

I've also opened #21 that fixes it for me locally...

from react-vega.

visnup avatar visnup commented on August 24, 2024

Can also check to see this failure by editing spec1.js in the demo dir to include a left axis format of ".1~%":

diff --git a/demo/src/vega/spec1.js b/demo/src/vega/spec1.js
index ae8e3ed..3ef594b 100644
--- a/demo/src/vega/spec1.js
+++ b/demo/src/vega/spec1.js
@@ -50,7 +50,7 @@ export default {
 
   "axes": [
     { "orient": "bottom", "scale": "xscale" },
-    { "orient": "left", "scale": "yscale" }
+    { "orient": "left", "scale": "yscale", "format": ".1~%" }
   ],
 
   "marks": [

from react-vega.

kristw avatar kristw commented on August 24, 2024

Umm, I think I know what happen. Let me take care of this. This component should not bundle vega-lib with it. I have to update webpack config to exclude the right library because the package name was changed from vega to vega-lib.

from react-vega.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.