possible memory leak about angular-slick HOT 7 OPEN

This will trigger when you change the view as well causing massive lag between views, unfortunately. Encountered that few days ago while creating my isotope wrapper.

from angular-slick.

@grabbou What do you mean by "this".

@deedarb's suggestion, or the plugin as is.

from angular-slick.

This = scope.$on('destroy') event. The thing is - when you have 100 items in your slider and you navigate to another route using ui-router causing the whole view to be rendered once again using different templates, you will notice massive lag as destroy will be called 100 times. AFAIK once item is removed from DOM, event listeners should be GC anyway. Haven't noticed any lags in my code because of that. $destroy can be called on main angular-slick directive to do the clean up but not on single elements tough.

from angular-slick.

@grabbou Event listeners on DOM elements (in the dom or not) are not automatically GC'ed. I don't think anyone is suggesting that $destroy is called 100 time for 100 slides. That would only happen when you have 100 instances of <slick> directive.

See this

from angular-slick.

Ah, sorry. I thought that we have 'sub directive' inside directive that displays every single slide. In that case, $destroy event is completely fine. In 99% cases though memory consumed by event handlers triggered on DOM elements is trivial compared to the overall memory used by a webpage. But again, having checked the code once again, it's an easy way to improve code quality.

from angular-slick.

I have tested for memory leak, and this does cause memoery leak. I have fixed this for now by by wrapping this in my own directive. Came here searching for existing issues before I make a PR, then noticed the source is coffeescript as mentioned in OP.

Please add a destroy handler.

from angular-slick.

@grabbou

memory consumed by event handlers triggered on DOM elements is trivial

Yes. But in angular this causes the detached elements to stay in memory, some of these elements holds references to scope(s), scope holds references to parent scopes, child scopes etc and they holds references to lots of data. Eventually those tiny handlers cause huge memory leak. This is a serious issue than just an improvement to code quality...

from angular-slick.