verify_authorized can only track authorize usage in controllers about pundit HOT 9 CLOSED

Fixing this would require using Thread locals or some other similar ugly hack. So I'm going to say this is outside the scope of the library.

from pundit.

@jnicklas Yes, when you want to use it with jruby or rubinius, then you have to use some thing like this:

module Pundit
  class NotAuthorizedError < StandardError; end
  class NotDefinedError < StandardError; end

  extend ActiveSupport::Concern
   THREAD_KEY_NAME = '_pundit_policy_authorized'
  class << self

     def policy_authorized?
       !! Thread.current[THREAD_KEY_NAME] 
     end

     def policy_authorized=(new_value)
         Thread.current[THREAD_KEY_NAME] =new_value 
     end

     def reset_policy_authorized
         policy_authorized = false
     end
  end 

from pundit.

@slowjack2k this has nothing to do with which Ruby implementation you use. Provided you use a threaded server (like Puma), this is a problem in MRI too. And thread locals really aren't a sensible solution for this, IMO.

from pundit.

@jnicklas It depends on the Ruby implementation. MRI has still a global interpreder lock.
Even with puma only one thread can run other thread's can only do IO. Changing class level instance variables is save as long as you don't use jruby or rubinius.

from pundit.

No, it's not.You don't have thread safe code per se when using MRI.

from pundit.

@tbuehlmann Ok, you'r right when you do IO a context switches can happen.

from pundit.

@slowjack2k no, that's incorrect. You misunderstand what the GIL does. Context switches can and do happen at any point in time, even with a GIL. Look up the difference between concurrent and parallel. MRI never executes Threads in parallel, but it definitely does execute them concurrently.

from pundit.

(should have said almost never, IIRC there are a few rare cases where MRI actually does execute multiple threads in parallel)

from pundit.

http://www.rubyinside.com/does-the-gil-make-your-ruby-code-thread-safe-6051.html is a good read.

from pundit.