Please update to work with rspec 3.0(beta) about pundit HOT 9 CLOSED

It would be really awesome if you could prepare a PR!

from pundit.

Pundit's RSpec matchers remain unchanged in #106, so I guess this issue is still open. Anyone else having trouble with the matchers in RSpec 3 or could give a hint what needs to be updated?

from pundit.

I'll see if I can actually fix what he was asking for and send another pull request :)

from pundit.

My pundit matchers were working in RSpec 3 beta1, but not beta2. Then again, beta2 broke half my test suite. :( Bleeding edge...

`failure_message_for_should_not` is deprecated. Use `failure_message_when_negated` instead. Called from /Users/yuval/Documents/webdev/homebuilder-web/spec/support/pundit_matcher.rb:10:in `block in <top (required)>'.

`failure_message_for_should` is deprecated. Use `failure_message` instead. Called from /Users/yuval/Documents/webdev/homebuilder-web/spec/support/pundit_matcher.rb:6:in `block in <top (required)>'.

from pundit.

Looks like the issue may actually be with Rails 4.1.rc1. I updated that from beta at the same time as rspec. Investigating further.

Yep, all specs passing with rspec beta2 (though I do get those deprecation warnings). Will have to figure out what the hell has changed in Rails 4.1.rc1.

from pundit.

I tracked down the issue. Very weird.

Here's my cut down policy and policy spec. Basically, an employee can view a Home if they are associated with it.

class HomePolicy < ApplicationPolicy

  def show?
    associated_home?
  end

  private

  def associated_home?
    @associated_home ||= user.homes.exists?(id: record.id)
  end

end

describe HomePolicy do
  subject { HomePolicy.new(user, home) }

  let(:company) { create(:company) }
  let(:home) { create(:home, company: company) }

  context "when employee associated with Home" do
    let(:user) { create(:employee, company: company, home_ids: [home.id]) }

    it { should permit(:show) }
  end

end

This spec fails with Rails 4.1.rc1 (false instead of true).

When I debugged the code, my check against user.homes.exists? was returning false. If I added a reload, it returned true. Alternately, using a before(:each) in the spec rather than associating the homes inline with the User factory also worked:

Fix option 1:

let(:user) { user = create(:employee, company: company); user.homes << home; user }

Fix option 2:

let(:user) { create(:employee, company: company) }
before(:each) do
  user.homes << home
end

from pundit.

I've submitted an issue to Rails core. 4.1.rc1 is broken.

rails/rails#14116

from pundit.

@uberllama I see your bug report helped fix this upstream in Rails. Does that close this issue?

from pundit.

It does indeed. Sorry, should have closed this one.

from pundit.