Code Monkey home page Code Monkey logo

Comments (1)

thomasklemm avatar thomasklemm commented on May 14, 2024

Your second approach sounds solid, I'd go with it to keep all policies related to the Course model in a CoursePolicy.

class CoursesController < ApplicationController
  before_action :set_project

  def create
    @course = @project.courses.build(course_params) # or Course.new(project: @project)
    authorize @course # is equal to authorize @course, :create?
    respond_with @course # or if @course.save ... else ... end
  end

  private

  def set_project
    @project = ...
  end
end

In the ApplicationPolicy there should be attr_reader :record, :user defined, so what I like to do in policies is alias the record method to whatever we're talking about, in this case, a record.

class CoursePolicy < ApplicationPolicy
  alias_method :course, :record

  def create?
    course.project && course.project.organizers.include?(user)
  end
end

In Rails, you could use delegate to shorten your query methods even a bit when this pattern repeats.

class CoursePolicy < ApplicationPolicy
  alias_method :course, :record
  delegate :project, to: :course

  def create?
    project && project.organizers.include?(user)
  end
end

Hope this clarifies things, though your second approach is already almost the same. Thoughts anyone? What could we do better?

from pundit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.