before_action instead of after_action for :verify_authorized? about pundit HOT 4 CLOSED

Oh, I think I just got it. Is this just a safeguard to make sure you realize your mistake in case you forgot to authorize your controller action?

Sorry (and feel free to close this issue) if this was just a misunderstanding!

from pundit.

@gabrielecirulli precisely!

from pundit.

Hi @jnicklas, I agree with @gabrielecirulli that this method definitely can give a false sense of security. The use of this after_action is a bit confusing/mis-leading. Is the original use case for developers to use this during development only to flag methods that don't call authorize? Is this to catch instances in production that don't call authorize? If the latter is the case, then the vulnerability will still exist for any state-changing controller action. If the former is the case, then does a developer just leave this in their code even though it shouldn't ever have any implications in production code? I went through the same thought process as @gabrielecirulli after reading that section.

I think at the very least, there should be an explicit warning in that section of the README for developers not to rely on this method in production and that state changing actions will persist even after the exception is raised.

from pundit.

Is the original use case for developers to use this during development only to flag methods that don't call authorize?

Yes.

If the former is the case, then does a developer just leave this in their code even though it shouldn't ever have any implications in production code?

Yes. Because the whole point is that code changes, and someone else might do something which causes authorization not to be performed. It's a safety net. Removing it removes the safety net.

This method will raise an exception if authorize has not yet been called.

I'm not really sure how we can make this much clearer. If you actually read this section, I think it's pretty clear what this is for. I'd be open to a PR improving the documentation here if you feel strongly about it.

from pundit.