Store non-persistent config files in ~/.cache/variety about variety HOT 4 OPEN

We are in 0.7.0 and Favorites is still under .cache :(

$ apt-cache policy variety
variety:
  Installed: 0.7.0-1
  Candidate: 0.7.0-1
  Version table:
 *** 0.7.0-1 500
        500 http://deb.debian.org/debian buster/main amd64 Packages
        100 http://deb.debian.org/debian unstable/main amd64 Packages
        100 /var/lib/dpkg/status

I had copied Favorites in another directory - removed everything from ~/.config/$ rm -rf variety just to see if Favorites were being copied to the new location in ~Pictures but apparently isn't :(

~/.config/variety/Favorites$ ls
atmosphere_geo5_2018235_eq2400.jpg  Dune.jpg  photo-1532274402911-5a369e4c4bb5.jpg  photo-1532298997262-7a61c25d245e.jpg

from variety.

I'll point out for the record that variety.conf and scripts/ are also designed to be configurable and should stay where they are. The others are probably movable.

from variety.

Favorites should quite definitely not be under .cache. They should probably move to be by default under ~/Pictures. Same goes for Fetched.
Of these probably into .cache should move Downloaded, history.txt, wallpaper, maybe variety.log. pencil_tile.png supports one of the filters that should probably go away, I doubt anyone uses it, not worth the added special logic for it.

from variety.

Revisiting this.

How does it go with the recently added option for multiple profiles? Profiles are right now tied to a single folder and I would definitely prefer to have it this way.
If we move Favorites / Downloaded / Fetched out of the profile folder into .cache, this would mean they would be shared between all the profiles. This may be good or bad, it depends. E.g. if you have summertime vs. wintertime or day vs. night profiles, you probably want the favorites separated too.

Another consideration is the migration strategy - I wouldn't like to have to move gigabytes of data around for every current user that has everything under .config, and additionally migrations are the hardest to test, most risky part of the system, and this would be a very high-impact, risky migration. This basically means that if we do it, we must do it only for new installations, without affecting existing installs. I.e. change just the default paths in variety.conf, and not anything else. Which means that existing users will have these folders in one place, new users - in another, which is a problematic setup for subsequent support.

Additionally all the "big" folders under .config - Favorites, Downloaded, Fetched - can be configured and moved to another location if they are problematic under .config.

As a whole, I see pros and cons both ways, and I wouldn't like to blindly follow a fairly generic guideline without considering them carefully. Generally I think this is one case where practicality probably beats purity. It is simply more practical from a developer's standpoint to have everything Variety-related under a single folder (especially judging by how many bugreports and questions from botched installations have ended with just "please rename your ~/.config/variety folder and restart"), I doubt too many users would actually care, and I would suppose that many users (e.g. me) would actually prefer to have the program contain all its files under a single folder.

@jlu5 what's your take?

from variety.