optional relations about fluent-kit HOT 4 CLOSED

@adtrevor I was thinking something like this:

@propertyWrapper
final class Parent<Value> {
    var _id: Any

    init(key: String) { ... }
}

extension Parent where Value: Model {
    var id: Value.ID {
        ...
    }

    func get(on database: Database) -> EventLoopFuture<Value> {
        ...
    }
}

extension Parent where Value: OptionalType, Value.Wrapped: Model {
    var id: Value.Wrapped.ID {
        ...
    }

    func get(on database: Database) -> EventLoopFuture<Value.Wrapped?> {
        ...
    }
}

The idea here is that the property wrappers don't have a hard requirement on the Value being a model. Instead, the property wrapper holds some type-erased properties (like _id: Any) and then those properties are interpreted in extensions that know exactly what type the model is.

That way @Parent var galaxy: Galaxy and @Parent var galaxy: Galaxy? can have different storage and different methods. This is useful because the required relation's get method should not return an optional. If it can't get the model for some reason, that should be an error. The second relation's get method should return an optional though.

However, as you said, this could get weird with init method overloads and stuff. I can't be sure whether or not this would work until I or someone else tries it.

from fluent-kit.

@OptionalParent was added a while back. Closing this.

from fluent-kit.

I think that all relations should be required by default, with the ability to specify an optional variant. I do not think that making all relations optional or even requiring something like RequiredParent would be good for beginners, readability, or maintainability. I have no preference as to whether it's @Parent with an optional property or @OptionalParent.

from fluent-kit.

If we can't go with solution number four, I agree with @mcdappdev: it would be better to avoid @Required* as I feel it would make the syntax "heavier" for what is probably going to be the most commonly used type of relation.

@tanner0101 When you say it's not clear wether or not 4) is makable, what are the main issues you are seeing? From what I just tried it's not possible to overload the property warper init so it seems like a dynamic cast is required, is this about performance you are worried?

from fluent-kit.