El Collectooorr review 18/07/22 `e7f5eae0c430444ac43aa70ea64c63a5f219bca7` about agent-academy-1 HOT 2 OPEN

• I wasn't aware of contract_method_call, is there any benefit to using it in comparison to what we have now?
• I have introduced constants in #90 for all the listed constants here.
• I agree it doesn't make sense to use enforce(), I have created an issue for it #91 , and it will be worked on it in a future version.
• Those unused functions are removed in #90 .
• For more complicated algorithms, we will need to use Tasks.
• The reason why this merging is done on the round is to avoid sending large payloads. Apart from it being kinda ugly, do you see any other issues?

from agent-academy-1.

I wasn't aware of contract_method_call, is there any benefit to using it in comparison to what we have now?

No there is no additional benefit apart from uniformity across repos.

The reason why this merging is done on the round is to avoid sending large payloads. Apart from it being kinda ugly, do you see any other issues?

I see, sending large payloads is not a good idea. One reason to keep all the processing on the behaviour side would be for example to separate the concerns or to enhance readability, i.e., it is easier to read a behaviour and understand the skill.
@DavidMinarsch would you have anything to add on this?

from agent-academy-1.