Code Monkey home page Code Monkey logo

Comments (16)

valorkin avatar valorkin commented on May 12, 2024

yes, I have seen this thing, but it is not relevant to ng2-bootstrap,
some of typings defining setInterval return value type as Timer,
what is obviously wrong, and should be number
only question is: who provides broken type definition?

from ngx-bootstrap.

valorkin avatar valorkin commented on May 12, 2024

@be4code so what starter are you using?

from ngx-bootstrap.

be4code avatar be4code commented on May 12, 2024

I'm using https://github.com/mgechev/angular2-seed but they told me how to use ng2-bootstrap with the seed.

from ngx-bootstrap.

valorkin avatar valorkin commented on May 12, 2024

ok, I have found it: https://github.com/borisyankov/DefinitelyTyped/blob/master/node/node.d.ts#L36-L39

from ngx-bootstrap.

ludohenin avatar ludohenin commented on May 12, 2024

Maybe you can just force the type (<number>yourVar) where using it ?

from ngx-bootstrap.

valorkin avatar valorkin commented on May 12, 2024

published as 0.44.5
@ludohenin please try

from ngx-bootstrap.

ludohenin avatar ludohenin commented on May 12, 2024

@valorkin didn't fixed the compiler error. But this did: private currentInterval:NodeJS.Timer; (line 56 of carousel.ts)

from ngx-bootstrap.

valorkin avatar valorkin commented on May 12, 2024

but then all will have to install node tsd even if they use ng2-bootstrap from .net
do you have a branch where I can reproduce this issue?

from ngx-bootstrap.

ludohenin avatar ludohenin commented on May 12, 2024

Yeah I know and it's a problem ... here is the branch

from ngx-bootstrap.

valorkin avatar valorkin commented on May 12, 2024

@ludohenin fixed in 0.44.6, setInterval type doesn't worse to force ppl use tsd :)

from ngx-bootstrap.

valorkin avatar valorkin commented on May 12, 2024

please approve and I am closing this issue

from ngx-bootstrap.

ludohenin avatar ludohenin commented on May 12, 2024

Works like a charm :)
I think you can close that one.
Thanks.

from ngx-bootstrap.

valorkin avatar valorkin commented on May 12, 2024

Write to me if anything :)
can you create a gh-pages for your repo?
so I can include it ng2-bootstrap readme

from ngx-bootstrap.

ludohenin avatar ludohenin commented on May 12, 2024

https://ludohen.github.io/angular2-seed-ng2-bootstrap
http://ludohenin.github.io/angular2-seed-ng2-bootstrap

from ngx-bootstrap.

ludohenin avatar ludohenin commented on May 12, 2024

I found this while roaming :). This how Timer issue is handled in ng2 source.
https://github.com/angular/angular/blob/master/modules/angular2/src/core/facade/async.ts#L10-L17

from ngx-bootstrap.

valorkin avatar valorkin commented on May 12, 2024

cool, looks good

from ngx-bootstrap.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.