TypeError at /accounts/login/: Object of type 'UUID' is not JSON serializable about django-allauth-2fa HOT 6 CLOSED

This is probably happening because we add user.id to the session (see https://github.com/percipient/django-allauth-2fa/blob/6d666d634ded380c4a7f660ac5a729fae095ffb2/allauth_2fa/adapter.py#L22-L24), which I guess is of type UUID? (I've never used a UUIDField, is the value a UUID object, not a string?)

It might work to cast to a string when adding it to the session, like: request.session['allauth_2fa_user_id'] = str(user.id)

from django-allauth-2fa.

That indeed worked. Thanks! I'll submit a PR today with the change.

from django-allauth-2fa.

I'm not sure how I'd write a good test in the current context. Since the current user model defaults to using IntegerField as the ID/PK, I supposed I'd have to write a dummy user model?

from django-allauth-2fa.

Awesome! 💥 Please include tests with your PR! I'll try to review it within the next few days.

from django-allauth-2fa.

I'll think a bit about how to test this.

from django-allauth-2fa.

I'll think a bit about how to test this.

@clokep Hi Patrick. Thank you for this response. I have run into a similar issue but this is when I try to login.
The registration part works fine, but logging in isn't quite working. My login parameters are email and password

What could I be getting wrong?

from django-allauth-2fa.