Next query paramater is not used when enabling 2FA about django-allauth-2fa HOT 9 CLOSED

I am currently working in a fix that pass forward all get parameters to address this issue and others like GA GET tracking parameters

from django-allauth-2fa.

This should be fixed now as #44 is merged.

from django-allauth-2fa.

Done: #51

Thanks

from django-allauth-2fa.

I was running the code tests and stumbled in 7 errors. Inspecting the travis build history i noticed that there are 7 tests being skipped, there is a special reason for that?

from django-allauth-2fa.

@humrochagf Some tests only run under Django 1.10.

from django-allauth-2fa.

this PR #44 should solve this issue

from django-allauth-2fa.

Hello guys sorry to awake this issue, but I am still experiencing the problem.

The PR #44 seems to make sure that when I visit /two-factor-authenticate?next=/my/path then the query parameter is passed correctly.

But I think there is still a problem before: when submitting the first user/password form, the next parameter might be passed with a POST parameter, and when this happens the next path is lost. And the default template for allauth actually passes the next as a POST parameter, and not as a url query.

See attached screenshot, I end up in accounts/profile instead of my desired path

I am running Django 1.11, allauth 0.32 and allauth-2fa 0.4.4

from django-allauth-2fa.

FYI I went around this problem by overriding the default allauth login template with something like this

<form class="login" method="POST" action="{% url 'account_login' %}{% if redirect_field_value %}?{{ redirect_field_name }}={{ redirect_field_value }}{% endif %}">

so the form's action attribute takes next parameter into account. But maybe allauth-2fa could benefit from handling the next parameter with POST as well

from django-allauth-2fa.

@ssimono Can you please file a new issue? It's easier to track instead of commenting on old issues. Thanks.

from django-allauth-2fa.