Integrate the bugfixes of Redis 7.2.5 about valkey HOT 16 OPEN

@SoulPancake Yeah. If you can, submit a PR cherry-picking the commits from unstable into the 7.2 branch. Thanks! I did review the list of changes from 7.2.5, and it looked like they were all commits from before the license change.

from valkey.

@SoulPancake Yeah. If you can, submit a PR cherry-picking the commits from unstable into the 7.2 branch. Thanks! I did review the list of changes from 7.2.5, and it looked like they were all commits from before the license change.

License changes from redis 7.4, so now cherry-picking is safe

from valkey.

I think for safety reasons (or for better conflict resolution), the release branch should be arranged by core-team members since in think we won't review it very carefully sometimes.

from valkey.

These were the commits
b3aaa0a
1f00c95
492021d
5fdaa53
763827c
da727ad

However, I guess there were some refactoring in valkey unstable on top this that also needed to be included

from valkey.

think for safety reasons (or for better conflict resolution), the release branch should be arranged by core-team members since in think we won't review it very carefully sometimes.

I agree with this, It's trickier than I thought to attempt the conflict resolution or choose which further commits to include
I am closing #567

from valkey.

I already checked our Valkey commit history, the 6 commits in Redis 7.2.5 already are included, this is why I close this issue.
Below is the detail PRs:

A single shard cluster leaves failed replicas in CLUSTER SLOTS instead of removing them (#12824)
b3aaa0a
Crash in LSET command when replacing small items and exceeding 4GB (#12955)
1f00c95
Blocking commands timeout is reset due to re-processing command (#13004)
492021d
Conversion of numbers in Lua args to redis args can fail. Bug introduced in 7.2.0 (#13115)
5fdaa53
redis-cli: --count (for --scan, --bigkeys, etc) was ignored unless --pattern was also used (#13092)
763827c
redis-check-aof: incorrectly considering data in manifest format as MP-AOF (#12958)
da727ad

Because all these PRs are in the Redis 7.2.5, they are safe in our Valkey repo.

from valkey.

@mkauf @madolson @zuiderkwast Folks, Can I take this up

from valkey.

Btw, we should have all the commits in our development tree, so you should ideally find the relevant commits from our unstable branch and cherry-pick those.

from valkey.

@enjoy-binbin This makes sense.

But to help prepare this, we first need to find the commits that we need to cherry pick. They can be posted as comments in this issue. That could save some time.

from valkey.

Today I check the commit in Reds 7.2.5, I think all code changes already are included in our unstable branch, please other core team member to double check Thanks @valkey-io/core-team

from valkey.

To close it because we have these parts code already

from valkey.

The plan is to cherry-pick the commits to our 7.2 branch and make a patch release.

from valkey.

Btw. I still think this overall approach makes sense. In Redis, one of the maintainers did all the backporting, but ideally we should do the backport with a PR.

from valkey.

@zuiderkwast @madolson I can send the backport PR

from valkey.

some of commits referred in #624 are already included.
(as i know) fork of valkey is created since redis' license changes.
so only we need is to cherrypick commits after changing will be fine.

from valkey.

btw, just wondering..
I have not yet checked whether exists or not, but,
if some commits approved in redis 7.4 and this commit has been applied also in 7.2 as backport, then can we cherrypick it?

from valkey.