Comments (4)
GooRiOn
commented on May 24, 2024
1
Ok I did the revert commit :D The PR #130 was created for this change :)
from valit.
paw3lx
commented on May 24, 2024
I think that it's good idea, because other types (int?, float? etc) already has Required rule. Of course we can also use MinLength, but it will be good to have Required rule in every nullable type.
from valit.
GooRiOn
commented on May 24, 2024
Honestly, I'm little bit surprised that we missed that :D We should go for it for sure 👍
from valit.
GooRiOn
commented on May 24, 2024
@tdeschryver I did this change since I had some free time. Unfortunately I didn't checkout to the new branch (I didn't notice error that I typed git checkout -b incorrectly) and I pushed changes directly to the develop... Since it's protected branch I can't revert this... Please take a look at this commit and if something will be wrong, I'll create a PR with fixes:
I'm sorry guys :/ My bad :/
from valit.
Related Issues (20)
- Asserts in tests HOT 1
- Broken develop HOT 7
- Features for v1.0.0 HOT 18
- Add more things for customising error messages HOT 2
- Validating nested objects - passing the IValitator<TObject> HOT 4
- Integrating with ASP.NET Core HOT 5
- Integrating with Autofac HOT 3
- Refactor resolving IValitResult from rules collection
- Remove IValitRulesProvider
- Resolve rules chain inside Validate
- Support for .NetStandard HOT 4
- Return custom result type from IValitResult<T> and IValitator<T> HOT 1
- Validation for reference types seems nonfunctional HOT 1
- Dont call .Satisfies() condition when .When() returns false HOT 1
- String MaxLength rule should accept empty string HOT 3
- Remove Microsoft.DotNet.Watcher.Tools from test project
- Question - Dependent Rules HOT 3
- Migrate to .NET Standard 2.1
- Migrate to .NET Core 3.1
- For(@object) throws exception when null
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from valit.