[Enhancement] isHash should validate algorithm name about validator.js HOT 5 OPEN

Let's put this behind a new option for backwards compatibility. Some projects might use both for user input and then they expect a boolean returned instead of an error.

So isHash would get an option bag which consists of validateAlgorithm. I would recommend setting the default to true, and then people can set it to false if they don't want this new validation

from validator.js.

Let's put this behind a new option for backwards compatibility. Some projects might use both for user input and then they expect a boolean returned instead of an error.

So isHash would get an option bag which consists of validateAlgorithm. I would recommend setting the default to true, and then people can set it to false if they don't want this new validation

Can you please add an enhancement label to this issue and assign it to me?

from validator.js.

Let's put this behind a new option for backwards compatibility. Some projects might use both for user input and then they expect a boolean returned instead of an error.

So isHash would get an option bag which consists of validateAlgorithm. I would recommend setting the default to true, and then people can set it to false if they don't want this new validation

so, if validateAlgorithm is set to true, should the function throw an error saying "Invalid algorithm" and return false?

from validator.js.

If it's set to true it should throw an Error, if it's set to false it will return false (the current behaviour)

from validator.js.

@WikiRik
PR for enhancement suggested. Please review.
#2296

from validator.js.