Support for zone index in IPv6 addresses about icmplib HOT 6 CLOSED

Hi @audeoudh 👋

Wow! Thank you for taking the time to detail your request.

I'll see how to implement this for the next release.

from icmplib.

I'll see how to implement this for the next release.

Just replace this line

self._sock.sendto(packet,socket.getaddrinfo(request.destination, port=None, family=socket.AF_INET if self._IP_VERSION == 4 else socket.AF_INET6, type=socket.SOCK_DGRAM)[0][4])

I've tested it and it looks like everything works

host = ping('fe80::d250:99ff:fe28:7d19%em1' ,count=10, interval=0.2, privileged=False)
(host.address ,host.avg_rtt ,host.is_alive ,host.jitter ,host.max_rtt ,host.min_rtt ,host.packet_loss ,host.packets_received ,host.packets_sent)
('fe80::d250:99ff:fe28:7d19%em1', 0.355, True, 0.17, 0.751, 0.139, 0.0, 10, 10)

host = ping('localhost' ,count=10, interval=0.2, privileged=False)
 (host.address ,host.avg_rtt ,host.is_alive ,host.jitter ,host.max_rtt ,host.min_rtt ,host.packet_loss ,host.packets_received ,host.packets_sent)
('127.0.0.1', 0.462, True, 0.093, 0.604, 0.386, 0.0, 10, 10)

from icmplib.

Hi @sunwire,

Sorry for the delay.

It is not so simple. I'm trying to avoid putting any code related to IPv6 in the ICMPSocket class. The ideal would be to place this code in the ICMPv6Socket class. However, this class does not have its own send method. I have to find a solution not to duplicate the code.

from icmplib.

The PR #38 does not add IPv6-specific code to ICMPSocket class. It forwards the self._sock.family and self._sock.type attributes to getaddrinfo. It works for both versions.

from icmplib.

I added tests to make sure that things works well with these modifications. Do you have a specific test bench to run to ensure all is working well?

from icmplib.

Hi @audeoudh, sorry for the delay...

Thank you for your PR! I have integrated some of your work in the version 3.0.2 of icmplib.
Otherwise, there are no unit tests at the moment, at least on GitHub. I have to improve them before committing them.

from icmplib.