Code Monkey home page Code Monkey logo

Comments (4)

mfouesneau avatar mfouesneau commented on May 7, 2024

For some reasons pip or conda did not install the git master properly and obtained an old version of at least vaex/file/other.py.

It seems corrected after forcing installation.
However, I suggest to raise an exception when no format was found.

from vaex.

maartenbreddels avatar maartenbreddels commented on May 7, 2024

Hi Morgan,

there are two issues here, one is a change in file format (the latest git has a better format that allows masked values), but it still understands the older format, and that you've resolved yourself.
The second issue is that if it fails to open a file, it will return None. The reason is that every reader is tried, so if the hdf5 one fails, it will try others and does not know for instance that a file should be able to be opened with the hdf5 reader but due to some bug failed to.

I think a better behaviour would be:

  • have a file extension to reader mapping, so .hdf5 will be tried by that specific class
  • if it fails, it will try all the others
  • and if that still didn't get to anything, it will print out the stacktrace by the initial attempt of opening the file

Do you agree?

cheers,

Maarten

from vaex.

mfouesneau avatar mfouesneau commented on May 7, 2024

I don't know if you want to check the extension itself. Sounds a good idea to try.
I suggested to raise an issue if none of the readers work. Of course that does not fully says why, but at least would not a code run with a None object.

from vaex.

maartenbreddels avatar maartenbreddels commented on May 7, 2024

Fixed in master a while ago.

from vaex.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.