Code Monkey home page Code Monkey logo

Comments (11)

jouni avatar jouni commented on September 24, 2024

Thanks for the feedback!

As a guideline, try to focus only on pointing out issues, without prescribing fixes at the same time. The team is responsible for working with the product designers in finding correct solutions.

That said, Iā€™m more than willing to spend time with the team to polish the UI if there is genuine interest in when the team has time to focus making the app look pretty and polished.

from bakery-app-starter-flow-spring.

jouni avatar jouni commented on September 24, 2024

There seem to be some weird bugs in the bakery styling that cause a lot of these issues.

For example, when inspecting the app, the body element has height: 0.1px as inline style. Where does that come from?

from bakery-app-starter-flow-spring.

manolo avatar manolo commented on September 24, 2024

body styles in the hosted page are defined via @BodySize flow annotation
https://github.com/vaadin/bakery-app-starter-flow-spring/blob/master/src/main/java/com/vaadin/starter/bakery/ui/MainView.java#L47

from bakery-app-starter-flow-spring.

manolo avatar manolo commented on September 24, 2024

Seems not be an issue anymore. Closing it.

screen shot 2018-03-02 at 10 47 43

from bakery-app-starter-flow-spring.

jouni avatar jouni commented on September 24, 2024

Is the online demo updated to show these fixes? At least bakery-flow.demo.vaadin.com looks different on iOS than the screenshot above.

from bakery-app-starter-flow-spring.

jouni avatar jouni commented on September 24, 2024

Same thing with bakery-flow-spring.app.fi

screen shot 2018-03-02 at 13 31 10

from bakery-app-starter-flow-spring.

manolo avatar manolo commented on September 24, 2024

Actually is updated, but for some reason the media query in iOS does not matches, interesting ...

from bakery-app-starter-flow-spring.

manolo avatar manolo commented on September 24, 2024

Seems a problem with bundling, the fix works in dev-mode but not when bundled.

This is the PR that apparently should fix the issue #484

@jouni any clue

from bakery-app-starter-flow-spring.

alexberazouski avatar alexberazouski commented on September 24, 2024

Seems it's bakery styling issue; reproduced on safari desktop.

from bakery-app-starter-flow-spring.

alexberazouski avatar alexberazouski commented on September 24, 2024

Is any of described bugs still an issue? I cannot reproduce it anymore

from bakery-app-starter-flow-spring.

johannesh2 avatar johannesh2 commented on September 24, 2024

Closing as fixed. Please re-open if needed.

from bakery-app-starter-flow-spring.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    šŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. šŸ“ŠšŸ“ˆšŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ā¤ļø Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.