consider making onig optional about findutils HOT 10 OPEN

regex is not a superset of either Posix BREs or EREs, since they both support back-references ((f)ire\1ox) while regex does not. I agree a comparison table would be nice.

Our glob implementation converts globs to Posix BREs, so any POSIX-compatible regex implementation gets us globs for free: https://github.com/uutils/findutils/blob/main/src/find/matchers/glob.rs

from findutils.

Yeah, compatibility is generally why we use onig instead of, say, the standard regex crate. I think we could probably make it optional as the additional features aren't used that much (in coreutils as well). It'd be great if there was some regex api that allowed us to switch with just a feature flag and wouldn't require us to write both versions everywhere.

from findutils.

ripgrep abstracted quite a bit so it can use pcre2 or regex.

from findutils.

https://gitlab.redox-os.org/redox-os/posix-regex might be a good option

from findutils.

I was convinced that regex supports a superset of the posix one. Probably would be good to make a table of what is supported and what is not. And do the same for the glob crates...

from findutils.

onig is still not updated, and clang-16 is going to hit more distributions. Given that upstream seems unresponsive should we start looking for alternatives more actively?

from findutils.

Am I missing some part of the conversation? What's going on with clang-16?

from findutils.

clang-16 makes onig non-buildable, I sent a patch to fix it more or less as I opened this issue.

from findutils.

Oh that's unfortunate. I wonder if https://crates.io/crates/fancy-regex be a good alternative?

from findutils.

That explains the error I'm getting when building this using MSYS2 / UCRT64, as that project recently updated to Clang 16.

from findutils.