Optimize availability check for "Run utPLSQL test" menu option about utplsql-sqldeveloper HOT 12 CLOSED

It's not working.

from utplsql-sqldeveloper.

@phsalvisberg
I would need to double check but I think it was reliable before.
Only develop (3.1.8-develop) had a bug as I went too far with optimizetions.
Let me check change history to see.

from utplsql-sqldeveloper.

@jgebal I checked. My JUnit test case fails with 3.1.7. All functions return false instead of true, because they do not update the annotation cache (without using the DDL trigger). I have not tested that with 3.1.8 yet. Maybe this is an issue there as well.

from utplsql-sqldeveloper.

The functionality was introduced in this change

Since then it wasn't changed until this change and then this change in 3.1.8-develop

I'm no sure why the functions don't work for you in 3.1.7. They should as they should update cache.
Perhaps it's not worth digging in old versions.

If this didn't work for you before 3.1.8, lets leave it active since 3.1.8 only.

from utplsql-sqldeveloper.

The problem is that has_suite, is_suite and is_test do not check if the annotation cache is up-to-date. This is a problem when you install utPLSQL with install_headless.sql instead of install_headless_with_trigger.sql. Hence this works in the develop environment and in our CI environment where install_headless_with_trigger.sql is used behind the scenes. These functions do not deliver a reliable result. Even in 3.1.8 :-(

from utplsql-sqldeveloper.

IMHO the functions should check if the DDL trigger is active. If not they have to update the annotation cache first. Similar logic as in get_suites_info.

from utplsql-sqldeveloper.

If this will not be fixed in 3.1.8 I'll have to undo this change.

from utplsql-sqldeveloper.

They do, and they always did.
line

    refresh_cache(l_owner_name);

Is responsible for doing the check and cache refresh.

from utplsql-sqldeveloper.

I can have a look at this in the evening.

from utplsql-sqldeveloper.

@jgebal Why have you reopened this issue?

from utplsql-sqldeveloper.

Because we're discussing it and As you said, you might need to revert the change.
Feel free to close if you want. I can open a different issue on utPLSQL

from utplsql-sqldeveloper.

Ok, I checked it again.
It works as expected (without trigger) in v3.1.8.
It does not work (without trigger) in v3.1.7. JUnit test fails.
Hence I close this issue.

from utplsql-sqldeveloper.