Sketch measure broken in Sketch 3.2 (9790) about sketch-measure HOT 12 CLOSED

P.S. your plugin is by far the most useful Sketch plugin in existence. Thank you so much for developing it:)

from sketch-measure.

I'll second what @allmakebelieve. We're daily users of sketch-measure. I'll take a look right now as well.

from sketch-measure.

Thanks @davidklaw! Pls let me know if you have any luck :) Should have known better than to use a beta on production work haha..

from sketch-measure.

@allmakebelieve I've found the problem but not the solution :)

These shape layers do not contain the "style" value (fills, borders, etc) as they had previously. When it's building out the label it sets the text color, which works just fine because it's handled differently, and then pulls the layer styles to add a new fill style. This fails because there are no styles. You can see this happening by looking at it in the UI - you can't add a fill or border.

from sketch-measure.

I'm at a standstill. Since "style" is no longer an available property I'm not sure how to add or modify the fill.

from sketch-measure.

Yep~ I'm not sure how to fix in 3.2 beta

from sketch-measure.

@utom @allmakebelieve

layer = [layer embedInShapeGroup]; will add the style property. Tested and confirmed to be working for 3.2 but I haven't checked for backwards compatibility yet - it's late here 🌃 Will try to put in a PR tomorrow unless someone beats me to the punch.

from sketch-measure.

@davidklaw awesome find. thanks for looking into it.

from sketch-measure.

@davidklaw did you have any luck in the end? Sorry to bug you - just have a project this'd be really handy for if you had any luck fixing it. Thanks so much.

from sketch-measure.

@allmakebelieve Oh, yes. I should have been more specific. Until a fix is committed go to common.js and add this line inside the else if (isShape(layer)) { line around 80.

layer = [layer embedInShapeGroup];

from sketch-measure.

@allmakebelieve Apparently I wasn't telling the entire story but you can dig around in this fairly straightforward PR. It should fix the problem in the App Store and Beta versions.

@utom

from sketch-measure.

Thank you so much, I had fix it. How did you know this?

from sketch-measure.