Comments (3)
Hi @kevinvandervlist thanks for the report. You are right that it would be desirable to mark the println
statement as dead code. But can it be done by the type checker? It all depends on the analysis of the condition of the while statement. Here it is trivial and this exceptional case could be added. In general, the type checker cannot decide whether the condition will be true or false without executing it. I will think about it what it requires to add such special casing.
BTW, we would prefer to have these and similar issues in the Rascal repo and reserve the issues here for TypePal specific issues.
from typepal.
Okay, thanks, will keep using rascal repo from now on.
I agree obviously, and it's not feasible it is to always do this, especially in general.
However, the current approach of marking this as Missing return code
, especially as an error, also seems to far off the actual situation. This reduces the value quite a bit I'd say.
It's obviously up to you, but a simple heuristic like 'there is a return
statement within the while
, so we might exit, therefore we mark this as a warning' seems to be much more helpful compared to the current error.
from typepal.
I have made a minimal fix for this specific case: usethesource/rascal-core@fff79a8
Maybe later more.
from typepal.
Related Issues (4)
- the project is missing its open-source LICENSE file and headers HOT 2
- github actions to release fail HOT 10
- The `syntax` rule in question in TypePal does not seem to be used: https://github.com/usethesource/typepal/blob/a0c06e638196bee17810d5dd2bbdb151fed26b5a/src/analysis/typepal/ConfigurableScopeGraph.rsc#L12
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from typepal.