urllib3 does not install if Python has no SSL support about urllib3 HOT 7 CLOSED

Marking as Urgent. Aiming to get this into the next release or the one after.

from urllib3.

@pudquick Can you confirm that this works as expected now?

from urllib3.

Please re-open this issue, it's still a problem, only different now:

File "urllib3/__init.py__", line 16, in <module>
    from .connectionpool import (
File "urllib3/connectionpool.py", line 75, in <module>
    class VerifiedHTTPSConnection(HTTPSConnection):
TypeError: Error when calling the metaclass bases
    cannot create 'NoneType' instances

It's progress, but looks like the new build is still attempting to subclass HTTPSConnection (when it doesn't exist / isn't available without SSL).

from urllib3.

@pudquick Ah right, I should have tested this more aggressively. I'll fix this ASAP tonight or tomorrow and push 1.2.1.

from urllib3.

Maybe instead of using HTTPSConnection = None on line 33 in connectionpool.py, you can use one of these recipes:

"Null" class: http://code.activestate.com/recipes/68205/
"Dummy" class: http://code.activestate.com/recipes/576447/

Or, since someone without SSL really doesn't care how the VerifiedHTTPSConnection object works ... you could also just "import HTTPConnection as HTTPSConnection". Not sure if this is the "right" way to do it, but would save injecting more code.

from urllib3.

@pudquick How about now?

I avoided doing HTTPSConnection = HTTPConnection because I think in some versions of Python there is actually a version of HTTPSConnection which does not depend on ssl (which does not do verification). So I think they're different things? I'm not completely sure.

from urllib3.

Closing it!!

Fantastic work, thank you so much. Both urllib3 and requests now work on this SSL-less environment :) So happy!

Thank you for all your hard work.

from urllib3.