Code Monkey home page Code Monkey logo

Comments (11)

shazow avatar shazow commented on July 22, 2024

You know I'm reluctant but it I agree we'll have to do this eventually.

Seems every major third-party Python package I check still supports Py25: Django, httplib2, SQLAlchemy, etc.

from urllib3.

takluyver avatar takluyver commented on July 22, 2024

It would also make Python 3 compatibility (#16) easier. It's not impossible to support older versions, but the code is cleaner if you can assume 2.6+.

from urllib3.

shazow avatar shazow commented on July 22, 2024

@takluyver If you're willing to start work on Py3 compat, I'm willing to drop Py25 support. :-)

from urllib3.

kennethreitz avatar kennethreitz commented on July 22, 2024

@shazow 🍰

from urllib3.

kennethreitz avatar kennethreitz commented on July 22, 2024

Requests plans to drop 2.5 when the switch to 3 occurs as well (unless it's not a burden, of course)

from urllib3.

takluyver avatar takluyver commented on July 22, 2024

I'll hopefully have time to look into it later.

from urllib3.

takluyver avatar takluyver commented on July 22, 2024

I'm struggling to get the test suite to run without eventlet (just on Python 2.7). The dummyserver has a fallback to wsgiref's simple server (and I've done a bit of work to get that starting and stopping), but there are several test failures. Any ideas?

Current state is at: https://github.com/takluyver/urllib3/tree/py3

from urllib3.

takluyver avatar takluyver commented on July 22, 2024

I've persuaded it to work with Tornado as the server for the tests (Tornado is compatible with Python 3).

from urllib3.

shazow avatar shazow commented on July 22, 2024

@takluyver Thank you for your efforts so far! You're right that dummyserver is a bit fragile and not all the tests pass with wsgiref, specifically the ones that test SSL certs (since wsgiref doesn't support that). Perhaps we should remove wsgiref fallback altogether.

I'm happy to accept a port of dummyserver to Tornado. I'm not very strict about adding dependencies to the test suite, and eventlet is rather hacky on many platforms so this would be a good tradeoff.

from urllib3.

takluyver avatar takluyver commented on July 22, 2024

See PR #35

from urllib3.

shazow avatar shazow commented on July 22, 2024

Done since merging python3 into master.

from urllib3.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.