netstandard issue about log4stash HOT 11 CLOSED

Thanks for the update!
We still need to fix that. I am not familiar enough with dotnet core so I will have to investigate a little bit this issue.

from log4stash.

Hey,
I've tested this library with .net standard and asp.net core and it works very well.
The screenshot you attached shows a warning and not an error.
This should work as it is.
@urielha I think in future versions we should improve that.

from log4stash.

@erangil2 well, it would work on Windows for sure, but have you tested it on Linux or in Docker? I have the same warnings and I believe it would not work in Docker.

from log4stash.

I actually did test it. I have multiple production services running on OpenShift containers, which is a Linux container, and they are working perfectly with the appended, you should try it yourself 😉

from log4stash.

I just tested it in Docker on Ubuntu 16.04 - it is working. Hmm... I wonder why compiler show that warning then?

from log4stash.

@aregaz It shows that so in case you have an error of any kind during runtime because of this issue you'll know where to look for it first.
However, it doesn't mean that by default it causes an error.

from log4stash.

Actually, the warning is shown because versions before 4.7.2 does not fully implement the netstadard2.0 interface. In 98% of the time you are OK.

from log4stash.

add my test here: currently use log4stash 2.2.1 and target as netcore2.1 will throw warning "Package 'log4stash 2.2.1' was restored using '.NETFramework,Version=v4.6.1' instead of the project target framework '.NETCoreApp,Version=v2.1'. This package may not be fully compatible with your project." during build, and test it works well which record logs.

from log4stash.

In the package there is no distribution for netstandard

from log4stash.

@urielha way back we did a hardfork. If it helps you could get anything from there: https://github.com/Elders/log4net.Appender.ElasticSearch

from log4stash.

Hi, now it should have :)
Please check version 3.0.0
And thanks to @erangil2 😄

from log4stash.