Different Args in "Action" and "Before" functions about cli HOT 8 CLOSED

It seems it is more inconsistent than that. If "Before" is nil, "Action" does not have its name at index 0.
example main.go: http://play.golang.org/p/dKDdOWqL8S

$ go run main.go foo 1 2 3 4
Args in Before: [1 2 3 4]
Args in Action: [foo 1 2 3 4]

$ go run main.go bar 1 2 3 4
Args in Action: [1 2 3 4]

from cli.

Confirmed, setting the "Before" function disables argument parsing of my defined flags. I removed Before functions completely.

from cli.

This is definitely a bug. Thanks for the report

from cli.

This bug is due to these lines (#L211):

// Run default Action
if len(a.Commands) > 0 {
    a.Action(context)
} else {
    a.Action(ctx)
}

@codegangsta, I think we should remove this if statement. It is apparently not necessary.

EDIT: There is already a discussion about this issue in the responsible commit.

from cli.

Addressed by #170

from cli.

Great, just found this bug as well and can confirm it. My research also found the lines above by ghigt.

The Ctx context haven't yet parsed the flags for the subcommand, but context context has and that one is used by the Before action, which makes it look like it works for Before, but not Action of the subcommand.

Any ETA when a fix can be merged to master?

from cli.

@rawn merged in today, let me know if your issue persists.

from cli.

@jszwedko Works beautifully!

from cli.