Deleting torrents without removing content about gearshift HOT 13 CLOSED

The 'remove' dialog provides two options for removal, deleting torrent and data, and only removing the torrent. What you want is already implemented, you just have to avoid pressing 'delete the data'

from gearshift.

I can indeed confirm that's not the case.

Gear Shift 1.0 from F-Droid.

When I click on 'remove', I got a dialog providing the two following choices:

• remove the data: that will remove the torrent content and the torrent file
• cancel: that won't do anything

Could it be possible that the localization (french here) hides something from me?

from gearshift.

There's also an 'OK' button right next to the cancel button. It's part of android's standard alert dialog. You're not seeing that?

from gearshift.

Nope, look :o

from gearshift.

maybe its because the string for the left button is too long, if you rotate the phone, does the 3rd button appear?

from gearshift.

Pppfff, guess what?

That's the problem...

In landscape I can see the three buttons.
In portrait, even if not visible, there is in fact a clickable area
corresponding to the "ok" button.

That wasn't present in version prior to 1.0

What could be done there? Revert to old traduction that wasn't buggy?

Cheers
Le 17 nov. 2015 9:21 AM, "Viktor Kojouharov" [email protected] a
écrit :

maybe its because the string for the left button is too long, if you
rotate the phone, does the 3rd button appear?

—
Reply to this email directly or view it on GitHub
#40 (comment).

from gearshift.

The dialogs use google's support library, so that's a bug in it. I guess I'll have to remove the button and add a checkbox instead, which unfortunately will lead to 2 taps if you want to delete a torrent and the data.

from gearshift.

Do all the translations also come from the lib? Or could those be shortened, mainly the first, longest one, to keep current way of functioning?

from gearshift.

A solution could be to have this long message (I didn't find a nice
alternative), displayed on 2 lines in smaller font.

That will lead to 3 buttons with more height.

Could it be possible to fix the width of each of the 3 buttons to 1/3 of
the width of the dialog? Thus, "forcing" the display on many lines if
needed.

Will be less nice, but will be working at least.
Le 17 nov. 2015 4:07 PM, "Viktor Kojouharov" [email protected] a
écrit :

The dialogs use google's support library, so that's a bug in it. I guess
I'll have to remove the button and add a checkbox instead, which
unfortunately will lead to 2 taps if you want to delete a torrent and the
data.

—
Reply to this email directly or view it on GitHub
#40 (comment).

from gearshift.

@Orppa the translation of the first button comes from the app. At least the english version is as short as possible while still trying to tell you what it will do.

@Stygmatik I don't think you get to have any customization options for these buttons, besides what the actual text is supposed to be

from gearshift.

So if current dialog would be kept, all the translations would have to be checked and possibly changed. Maybe it's just easier and safer to think of an alternative way. The one you already suggested, or something else.

Having one extra tap opposed to not having a button visible sounds still better option.

from gearshift.

I was thinking also about the extra tap.
Could in fact be seen as a security tap for the data also.

Or you could shorten "Supprimer les données" in "Suppr. Donn." Should fit.

Last option: is it possible to have an horizontad scroll of the text (back
and forth) on a button ? To keep a fixed width.
Le 18 nov. 2015 6:26 AM, "Orppa" [email protected] a écrit :

So if current dialog would be kept, all the translations would have to be
checked and possibly changed. Maybe it's just easier and safer to think of
an alternative way. The one you already suggested, or something else.

Having one extra tap opposed to not having a button visible sounds still
better option.

—
Reply to this email directly or view it on GitHub
#40 (comment).

from gearshift.

The neutral button is now a checkbox. It's default state can be set from the general settings.

from gearshift.