examples/{u,glx}play: incorrect stride on some sources about upipe HOT 8 CLOSED

It works with uplay -s 856x480 although the file is 854x480

from upipe.

glxplay is different because it uses rgb24 rather than rgb15

from upipe.

diff --git a/lib/upipe-av/upipe_avcodec_decode.c b/lib/upipe-av/upipe_avcodec_decode.c
index bf674ca8..46b4c969 100644
--- a/lib/upipe-av/upipe_avcodec_decode.c
+++ b/lib/upipe-av/upipe_avcodec_decode.c
@@ -295,8 +295,8 @@ static int upipe_avcdec_get_buffer_pic(struct AVCodecContext *context,
     }
 
     UBASE_FATAL(upipe, uref_pic_flow_set_align(flow_def_attr, align))
-    UBASE_FATAL(upipe, uref_pic_flow_set_hsize(flow_def_attr, context->width))
-    UBASE_FATAL(upipe, uref_pic_flow_set_vsize(flow_def_attr, context->height))
+    UBASE_FATAL(upipe, uref_pic_flow_set_hsize(flow_def_attr, context->coded_width))
+    UBASE_FATAL(upipe, uref_pic_flow_set_vsize(flow_def_attr, context->coded_height))
     UBASE_FATAL(upipe, uref_pic_flow_set_hsize_visible(flow_def_attr, context->width))
     UBASE_FATAL(upipe, uref_pic_flow_set_vsize_visible(flow_def_attr, context->height))
     struct urational fps;

from upipe.

@cmassiot ?

from upipe.

That change works as expected here.

from upipe.

Additionally, shouldn't upipe-gl use hsize_visible and vsize_visible somewhere to crop the visible surface?

from upipe.

I don't think this is the appropriate patch for several reasons :

• hsize_visible and vsize_visible are currently unused in upipe and I'm thinking of deprecating them. It is due to the fact that it is an internal codec value, and it is equivalent to doing ubuf_pic_alloc(codec_size) then ubuf_pic_resize(visible_size)
• it doesn't fix the real bug in upipe-gl which is that it considers that width == stride.
  The attached patch fixes the last issue. It is wrong however as pixels beyond the width shouldn't be displayed, but I don't know how to do it with the OpenGL API.
  upipe.txt

from upipe.

Fixed by ec36886

from upipe.