Comments (9)
correct there is no install target defined. i dont really know how it works but im open to a PR or maybe i will look into it at some point in the future
from abaddon.
The current state is somewhat problematic, IMO, since it is not just that target is completely absent (which is kinda fine, at least a user will get an error or sees nothing being installed): it is present, but installs some random stuff without installing the main thing :)
So an impression may be that the app is broken, but it is not the case really.
from abaddon.
@ouwou Took a bit of time to sort this out, but I have it running now on a PowerMac in 10.6 ppc :)
Not sure if a voice chat will work, but at least it is actually running. Astonishing!
from abaddon.
voice chat should work :^)
im guessing the "random stuff" you refer to is maybe because of subprojects? im not sure how all the install stuff works. i could try and figure out how to write an install target but might take some fiddling cuz of resources. perhaps i should finally figure out glib's resource management since i think that embeds most of it in the executable and would simplify stuff a lot
from abaddon.
im guessing the "random stuff" you refer to is maybe because of subprojects?
Yes. IMO, it should either install everything which is chosen via configure args (and obviously, the main binary), or install nothing (leaving it to a user). The second choice is not great, since it may not be obvious, what exactly should be installed and where.
But with existing setup what I got initially was installation of side components without the main binary. So it looked like it installed successfully, but it was completely unusable.
For Macports, I used externally installed dependencies, so that we do not need to fetch submodules and possibly build duplicate libraries. And we handle installation manually via destroot phase in portfile.
But it will be nice to have it fixed for everyone.
from abaddon.
And indeed, main CMakeLists have nothing about installing of what they build
The thing with packaging/installing is, that I originally wanted it to be all statically packaged and I made a sort-of proof of concept for a nonstatic .app build on #207. I currently still use that Abaddon.app approach but problem being is that I couldn't get static builds working at all and left it as is.
from abaddon.
@TheMorc Could you share contents of the bundle with paths? I can try reproducing it locally.
(I am not planning to copy duplicate libs inside the bundle, but we can simply symlink those to mimic what the app expects.)
from abaddon.
@TheMorc In fact Macports has a portgroup which implements app packaging, I can see if that gonna work.
from abaddon.
@barracuda156 nothing is really that much different in the app bundle from that zipped one in the other PR, the executable doesn't really need symlinks or any lib gymnastics to get working. I just wanted it to have them packed there for the simplicity that you could download a build without building it yourself.
Abaddon.app:
Contents:
Info.plist
MacOS:
abaddon
Resources:
Abaddon.icns
css
fonts
res
from abaddon.
Related Issues (20)
- [Suggestion] Option to show only the channels of currently selected guild HOT 4
- Links colored black after PR #252 HOT 3
- No Audio at VC Move HOT 2
- Error while building (WINDOWS) HOT 8
- [remote-auth-ws] [error] Websocket error: Status: 0 Reason: Unable to connect to remote-auth-gateway.discord.gg on port 443, error: OpenSSL failed - error:0A000086:SSL routines::certificate verify failed HOT 2
- Default folder for resources and css on macOS is really odd and no configure option available to set the right path HOT 5
- macOS needs a several fixes for subprojects: how to do that, technically? HOT 2
- URI handler opens links and pictures in MS Word HOT 4
- Consider changing (removing) QR code colours. HOT 3
- Latest version ignores "mobile = true" ini flag HOT 2
- IXSocketOpenSSL.cpp:(.text+0xe98): undefined reference to `SSL_get_peer_certificate' HOT 6
- [Feature Request] Functionality Expansion HOT 2
- abaddon.exe - System Error HOT 1
- Internationalisation HOT 6
- Allow changing audio devices HOT 1
- build number could not be fetched HOT 10
- Text emotes starting with : not usable HOT 2
- Failing to build on Mac OS X HOT 2
- segfault with musl libc HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from abaddon.