Code Monkey home page Code Monkey logo

Comments (8)

mintar avatar mintar commented on August 27, 2024 1

You mean, sick_tim has USB support and sick_scan doesn't, right? And you want to ask about porting sick_tim to ROS2?

If you want to prepare a pull request to port sick_tim to ROS2, I'd be happy to review and merge it!

from sick_tim.

mintar avatar mintar commented on August 27, 2024

No, this repo is in maintenance mode, and I'm not planning on doing further development on it. There is a more up-to-date fork of this repo here, which also supports ROS2: https://github.com/SICKAG/sick_scan_xd

from sick_tim.

Noel215 avatar Noel215 commented on August 27, 2024

I already opened an issue in the past asking for USB support, but they are not interested in maintaining it so I wanted to know if there was any plan to port/maintain it in this repository for ROS2.

Thanks!

from sick_tim.

atzaros avatar atzaros commented on August 27, 2024

Hi there

As @Noel215 mentioned, we prepared a PR to support SICK TIM with USB support in ROS2.

That's what we did:

  • we used Stratom Inc. foxy-devel branch to bring up ROS2 support
  • we applied ROS2 conventions about linters and we make them happy
  • some warnings fixed due to -Wpedantic introduced by Stratom Inc.
  • Tests passed in a TIAGo robot with a USB TIM 551 with ros2_navigation and rviz

from sick_tim.

atzaros avatar atzaros commented on August 27, 2024

I cancelled PR #100 and I opened #101 with a cleaner git history with the same aims as stated before.

Sorry for the noise

from sick_tim.

atzaros avatar atzaros commented on August 27, 2024

@mintar just pinging. Do you think #101 can be merged?

from sick_tim.

mintar avatar mintar commented on August 27, 2024

Yes, thanks for the ping. I just created a new branch humble, rebased your PR and merged it. BTW, we have a Tiago robot as well (but still on ROS Kinetic). :)

from sick_tim.

atzaros avatar atzaros commented on August 27, 2024

Ah! Nice to know.
Hope you enjoy our little creature... and this patch soon!

from sick_tim.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.