v0.59.3 breaks VSCode about unocss HOT 14 CLOSED

@antfu @Simon-He95 I was able to reproduce the issue. Please check https://github.com/tobiasdalhof/unocss-issue-3733/

VSCode slows down when I open my laravel routes file. It contains a fair amount of square brackets, which is probably causing the issue

Regular expression was recently changed in #3712

Thank you very much for providing a particularly detailed reproduction demo.

from unocss.

@Simon-He95 Can you help to take a look? Thank you

from unocss.

Probably caused by #3728

from unocss.

Probably caused by #3728

hi, @tobiasdalhof can you provide a reproduced demo

from unocss.

Hey @Simon-He95,

I'm unable to whip up a demo for you right now, but here are some additional details: I've got a monorepo using pnpm. Inside, I've got a bunch of frontends built with Vite, and they all share a single unocss.config.ts file.

Here's what my repo structure looks like:

📁 /backend
📁 /frontend-1
  📄 package.json
  📄 vite.config.ts
📁 /frontend-2
  📄 package.json
  📄 vite.config.ts
📁 /frontend-3
  📄 package.json
  📄 vite.config.ts
📄 package.json
📄 unocss.config.ts

And here's a snippet from a vite.config.ts file as an example:

import { resolve } from 'node:path'
import { defineConfig } from 'vite'
import UnoCSS from 'unocss/vite'

export default defineConfig({
  plugins: [
    UnoCSS(resolve(__dirname, '../unocss.config.ts')),
  ],
})

Let me know if you need more info or if there's anything else I can assist you with.

from unocss.

@tobiasdalhof,
If possible, please provide a link to the smallest reproduction warehouse so that I can better troubleshoot, thx~

from unocss.

I was able to solve the issue by adding a unocss.config.ts to each package. My structure now looks like this:

📁 /backend
📁 /frontend-1
  📄 package.json
  📄 unocss.config.ts
  📄 vite.config.ts
📁 /frontend-2
  📄 package.json
  📄 unocss.config.ts
  📄 vite.config.ts
📁 /frontend-3
  📄 package.json
  📄 unocss.config.ts
  📄 vite.config.ts
📁 /shared
  📄 package.json
  📄 unocss.config.ts
📄 package.json

Helper function in /shared/unocss.config.ts to create UnoCSS UserConfig:

import type { UserConfig } from 'unocss'

export function createConfig(): UserConfig {
  return {
    // ...
  }
}

from unocss.

@tobiasdalhof Can you help me test whether this version of the plugin can solve this problem? Please disable unocss and use this test version unocss-test

from unocss.

@tobiasdalhof Can you help me test whether this version of the plugin can solve this problem? Please disable unocss and use this test version unocss-test

@Simon-He95 Thanks for looking into it. The issue still persists

from unocss.

@tobiasdalhof Can you help me test whether this version of the plugin can solve this problem? Please disable unocss and use this test version unocss-test

@Simon-He95 Thanks for looking into it. The issue still persists

I think the best way is for you to provide a repo that reproduces the problem you mentioned so that I can track it.

from unocss.

We temporarily closed this due to the lack of enough information. We could not identify whether it was a bug or a userland misconfiguration with the given info.
Please provide a minimal reproduction to reopen the issue.
Thanks.

Why reproduction is required

from unocss.

@antfu @Simon-He95 I was able to reproduce the issue. Please check https://github.com/tobiasdalhof/unocss-issue-3733/

VSCode slows down when I open my laravel routes file. It contains a fair amount of square brackets, which is probably causing the issue

Regular expression was recently changed in #3712

from unocss.

@Simon-He95 @antfu

Hi, I have the same issue with this problem.

the test file is:

https://github.com/tobiasdalhof/unocss-issue-3733/blob/main/test.php

with

Route::get('/some-route', [SomeController::class, 'someMethod']);
Route::get('/some-route', [SomeController::class, 'someMethod']);
Route::get('/some-route', [SomeController::class, 'someMethod']);
...

and my api.php for laravel router is:

Route::get('test', 'TestController@index');
Route::get('test', 'TestController@index');
Route::get('test', 'TestController@index');

I clone https://github.com/tobiasdalhof/unocss-issue-3733/ this repo

and it still happend on unocss 0.59.4 vscode extension

from unocss.

@Simon-He95 @antfu

Hi, I have the same issue with this problem.

the test file is:

https://github.com/tobiasdalhof/unocss-issue-3733/blob/main/test.php

with

Route::get('/some-route', [SomeController::class, 'someMethod']);
Route::get('/some-route', [SomeController::class, 'someMethod']);
Route::get('/some-route', [SomeController::class, 'someMethod']);
...

and my api.php for laravel router is:

Route::get('test', 'TestController@index');
Route::get('test', 'TestController@index');
Route::get('test', 'TestController@index');

I clone `https://github.com/tobiasdalhof/unocss-issue-3733/` this repo

and it still happend on unocss 0.59.4 vscode extension

0.59.4 did not merge this pr😂

from unocss.