Comments (9)
Have you seen this as an actual problem today? Could you share some traffic charts @Meemaw?
Our experience running the proxy for customers in Unleash Cloud is that they usually will never start at the same time, just because of how the scheduler will provision instances.
But, I think actually the main problem is to not have them start sending metrics at the same time, so the first time metrics are sent should actually be random number in the defined metrics interval.
What do you think?
from unleash-proxy.
Actually, it seems posting metrics is the main issue. Here is a chart
from unleash-proxy.
Hey! Sorry for the long delay here 🙋
Yeah, we agree that this sounds like a sensible thing to add. Whether it'd be better to add jitter only for the first send and then send at regular intervals thereafter or to add jitter for every request is still uncertain, but that can be discussed and decided.
Anyway, would you be willing to make a PR for this? We'd be happy to provide guidance, of course 😄
from unleash-proxy.
@thomasheartman this would have to be implemented in each client separately, right? For proxy in particular, that would be node client.
from unleash-proxy.
I think if we only jitter on the initial metrics startup, we would only have to update the unleash-proxy package. PR above.
from unleash-proxy.
Yeah, if you only add it to the startup, then it should suffice to only update the proxy, but as you mentioned in the PR: it might make more sense to add jitter for every request. That would require updates both to the Node SDK and to the proxy.
from unleash-proxy.
Node SDK v3.18.0-beta.0
introduced support for jitter on the metrics interval.
We need to be mindful that the proxy customize the metrics sligthly (see code)
In addition we need to expose the same jitter option in the proxy (also as an environment variable).
from unleash-proxy.
Released as part of v0.14.0-beta.0
.
Do you mind testing it a bit @Meemaw ?
from unleash-proxy.
@ivarconr We still use fairly old version of proxy, mainly due to #86
from unleash-proxy.
Related Issues (20)
- Pass `req` to context enrichers HOT 6
- Connecting to gitlab ERROR: Error: Unleash Repository error: Response was not statusCode 2XX, but was 401 HOT 1
- The Proxy API returns all feature toggles, even those from projects that are disabled for the requested environment HOT 4
- use `logger.debug` in `getAllToggles` HOT 3
- OpenAPI gets broken when using PROXY_BASE_PATH HOT 1
- Unleash Proxy does not return Feature flags for dev environment HOT 4
- Add option to expose metrics via prometheus endpoint HOT 3
- Server side token config no long working in latest version v0.16.3 HOT 3
- CORS_ORIGIN doesn't support a comma separated value contrary to what's stated in the docs HOT 1
- Add CurrentTime to createRequestParameters HOT 5
- Fix vuln CVE-2023-6237 docker image update HOT 1
- Add x-unleash-proxy-version header to the proxy HOT 3
- `proxyBasePath` requires leading slash to work correctly HOT 2
- Unexpected behavior when isEnabled in Custom Strategy definition has an exception thrown HOT 4
- CORS Configuration does not apply for 304 refresh requests HOT 4
- Disable prometheus endpoint HOT 4
- Return disabled toggles as well on the proxy endpoint HOT 27
- Problem Running on AWS Lambda HOT 17
- Allow configuring the value for httpOptions.rejectUnauthorized via Environment variables HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from unleash-proxy.