Comments (14)
Thanks for feedback.
We have to fix this issue by changing the fromTime value. (without copying array)
from i-simpa.
After reading again the code:
The implementation follow the ISO 3382:1997(F)
. The reverberation time RT30 is computed using the regression on a Schroeder curve from -5db to -35db.
The variable wxFloat32 fromTime
is the time when the value is -5 dB inferior than the higher value of the Schroeder curve.
from i-simpa.
All this post-processing code will be moved into lib_interface and included into the automated unit test framework.
from i-simpa.
The RT calculation is ok. The bug is in energetic parameters calculation (mainly C and D). The integration should start when the impulse arrives to the receiver not from t=0.
from i-simpa.
If you look at for example projet_calculation.cpp in C param calculation there is:
wxFloat32 wj_CurrentFreq=GetSumLimit(idFreq,0.f,te,timeTable,tab_wj)/GetSumLimit(idFreq,te,-1.f,timeTable,tab_wj);
The problem is that instead of starting integration from fixed 0 it should start when direct sound approaches the receiver. It can be changed in parameter calculation funcition or GetSumLimit method.
This applies to all energetic parameters.
from i-simpa.
Yes sorry, I was focused in RT and EDT. I reopen the issue and I will fix it by updating
Compute_ST_Param
Compute_C_Param
Compute_D_Param
Compute_TS_Param
Compute_LEF_Param
Compute_LF_Param
Compute_LFC_Param
Compute_LG_Param
Compute_G_Param
from i-simpa.
I try to validate this modification. However, I obtained NaN or °Inf values for all parameters (except reverberation parameters).
Need to verify step by step the calculation, in debug mode.
Below, a simulation (v1.3.4) for a 10m cubic room, source at the center, receiver at 2m from the source:
50Hz to 1250Hz, increasing absorption from 0, step 0.05, d=1 (100% diffuse)
1600 and 2000 Hz, absorption 0.1 and 0.2 respectively, no diffusion d=0
from i-simpa.
May be a problem in this function. Is-it for finding the time step of direct field? lastdb
should not be updated at each time step?
Time step of the direct field (if exists) could be estimated simply by calculating the distance from source;
If no direct field ?
from i-simpa.
Yes it could be that. GetTimeDecay should return the time before the noise level is decaying .
from i-simpa.
Are you sure it finds the time step of the direct field (or a valid change/increasing of energy)?
from i-simpa.
With I-Simpa in dev branch I have this:
What is the timestep in spps ?
issue_7.zip
from i-simpa.
ok, there is an issue when sound power received is < 0 dB. I will try to fix that
from i-simpa.
May be that results are correct. I have prepared a I-Simpa project with the possibility to compare results with expected values for C, D...
from i-simpa.
I have compared SPPS and expected theoretical results for 100% diffusing room, in many room size (verifying also the effects of the Time Step and distance from source). It seems that the procedure for calculating the clarity C80 within I-Simpa seems correct. It probably needs further validation with measurements or other reference data, but it seems quite acceptable for now.
from i-simpa.
Related Issues (20)
- Access of csbin files HOT 1
- Table for LF and LFC results give dB values with too many digits
- How we can do the simulation for a each full floor from a building, not only one room/space ?
- How we can import the model of building with doors and windows from Revit to I-simpa without getting errors in meshing? HOT 2
- Changing Surface Material through Python script HOT 6
- Remove unwanted column in window "Viewing style" for graph parameters
- my problem in the simulation with a suspended surface HOT 7
- remeshing crashes depending on model scale HOT 1
- Selection of small faces in the UI
- Determination "pink noise" spectrum in sound source HOT 2
- Punctual receiver. inconsistent data output HOT 1
- Add evaluation of Uncertainties in the results
- Program does not load HOT 4
- LookupError: No spectrum for the given name exists (Water). Try one of: [] HOT 2
- Results not correct HOT 1
- Problem with I SIMPA'S SPPS calculation HOT 1
- Switch to ray tracing library HOT 2
- Warning: point #27 is coincident with #108. Ignored HOT 1
- Add pyroomacoustics with I-Simpa
- SPL calculation with surface receiver HOT 12
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from i-simpa.