Code Monkey home page Code Monkey logo

Comments (3)

SubJunk avatar SubJunk commented on July 18, 2024 1

I think it has always been an OR match on those, but I can see the LoadingPriority is too high here so I have changed it in #4118. I hope that will fix it

from universalmediaserver.

Mik-S-UMS avatar Mik-S-UMS commented on July 18, 2024

I think when that conf was made for the VR feature the author assumed it was AND.

There are also a few other confs for android that use "Android" in UserAgentSearch so that must be why this was given a higher priority. This could stop the valid matching for users of pigasus though.

Might be better to remove "Android" and just use "Hanging Hat Studios" if it uses OR. I tried to find any logs on the forum from users of pigasus to get the headers but could not find any so don't know what would be a better match.

I think it would be better if AND was used when both UserAgentSearch and UpnpDetailsSearch are defined in the conf to get more accurate matches and less false positives. This should help with things like the Samsung-NotCD.conf being used instead of the Samsung-CD.conf for newer TVs, which is also another fairly common thing I see. And there is also the ability for the user to change the device name so could use the modelName in UpnpDetailsSearch and have something more generic in UserAgentSearch to match instead.

Another solution is to have it so if both UserAgentSearch AND UpnpDetailsSearch match to one conf then automatically give that a higher priority over anything that just matches UserAgentSearch OR UpnpDetailsSearch instead of needing to set the LoadingPriority in the conf.

from universalmediaserver.

SubJunk avatar SubJunk commented on July 18, 2024

Ok, I have removed Android in #4121

from universalmediaserver.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.