Comments (7)
Hey, so sorry I didnt respond here, for some reason I didnt get notifications of this, im happy with those bits just being added but if you wish to make it more flexible in the future I cannot see a downside to that.
from unity-atoms.
I'm pretty sure this is an oversight. probably because Ints and Floats where created before the Generation stuff was written and before x2 events/listeners where introduced.
There are missing x2 listeners for:
Bool, Collider2D (has no x2 event, too), Color, Float, GameObject, Int, Vector2, Vector3, Void.
There are x2 listeners:
String, TouchUserInput
It should be possible to write a Test that covers, that for each Event-Type there is also an Listener-Type
from unity-atoms.
Thanks for submitting the issue!
This has been overlooked. Will be continue working on the generator this weekend, so all the missing ones will be added to the canary branch.
Would you consider it useful if the generator was able to generate atoms that are of different types? Eg. IntStringListener or FloatIntEvent?
from unity-atoms.
Would you consider it useful if the generator was able to generate atoms that are of different types? Eg. IntStringListener or FloatIntEvent?
since those x2 events are usually used for "ChangedWithHistory"-events on a variable, and because there are a lot of combinations possible (IntString, StringInt ?) and if needed those classes can be created by the library user for the types needed. I'd vote against adding all those combinations
from unity-atoms.
Maybe I was unclear in my question :) I totally agree that we should not add all of them to the project, however do we think it would be helpful to add the possibility to be able to generate those via the code generator when needed?
from unity-atoms.
IntIntListener was added in cb20008
from unity-atoms.
@grofit Thanks! Will create a new issue regarding expanding the generator!
from unity-atoms.
Related Issues (20)
- [FEATURE] Upgrading Documentation to Docusaurus 2.x and adding a search plugin
- [BUG] NullReferenceException in HandlePlayModeStateChange HOT 1
- [BUG] AtomValueList keeps runtime modifications HOT 1
- [BUG] AtomValueList not compatible with disabled domain reload HOT 1
- [FEATURE] Improve Inspector legibility
- [BUG] FiniteStateMachine not firing events anymore HOT 2
- A number of issues with AtomLists/AtomCollections HOT 2
- [FEATURE] More public get-properties for fields HOT 2
- [QUESTION] Subpackages documentation HOT 2
- [FEATURE] Variable Resetter shouldn't trigger due to script hot reload
- [FEATURE] Clear "AtomList" and "AtomCollection" OnEnable
- [FEATURE] SceneField for Addressable Scenes
- [BUG] StackTraces allocate garbage when DebugMode = false HOT 1
- [BUG] QuaternionReferenceDrawer Rendering issue HOT 1
- [BUG] CustomStruct Reference Drawer Rendering issue
- [FEATURE] AtomTags - Update TagInstances in Editor
- [FEATURE] Auto drag and drop atom references through inspector without the need to manually switch usage type
- [FEATURE] AtomBaseEventReference to have `Raise` methods inside
- [FEATURE] VFX PropertyBinder HOT 1
- [BUG] Recompiling during play mode resets all variables HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from unity-atoms.